[comp.windows.interviews] fix2 for 3.0-beta

interran@lurch.Stanford.EDU (John Interrante) (05/03/91)

John Vlissides archived his fix for the 8-bit character problem in
~ftp/pub/3.0-fixes/fix2 on interviews.stanford.edu.  For people's
convenience, I'll enclose the contents of fix2 in this message.
-- 
	Apply with ``patch -p -N < fix2'' at the top of the source tree.

Newsgroups: comp.windows.interviews
From: vlis@lurch.stanford.edu (John Vlissides)
Subject: Re: more idraw enhancement suggestions
In-Reply-To: rosen@polar.bu.edu's message of 29 Apr 91 01:56:42 GMT
Organization: stanford university
Distribution: comp,world
Date: 30 Apr 91 12:08:56

In article <ROSEN.91Apr28215642@polar.bu.edu> rosen@polar.bu.edu (David B. Rosen) writes:

   2) Ability to use the entire postscript character set in text objects
   (not just the bottom 128!).

3.0 idraw is meant to support such characters via the Meta key;
however, there is a bug that prevents this from working consistently.
Below is the patch:

*** /interviews/dist/3.0-beta/iv/src/lib/Unidraw/manips.c	Thu Apr  4 22:46:50 1991
--- iv/src/lib/Unidraw/manips.c	Tue Apr 30 12:03:29 1991
***************
*** 608,614 ****
          case '\015':  if (_multiline) InsertCharacter('\n'); break;
          case '\033':  manipulating = false; break;
          default:
!             if (!iscntrl(c)) {
                  InsertCharacter(c);
              }
              break;
--- 608,614 ----
          case '\015':  if (_multiline) InsertCharacter('\n'); break;
          case '\033':  manipulating = false; break;
          default:
!             if (!iscntrl(c & 0x7f)) {
                  InsertCharacter(c);
              }
              break;

   7) Constrained move, like on the mac.  I.e. when you hold down the
   shift key during a move, you can move the object horizontally or
   vertically, but not both.  (Suggested by Gary Bradski I think.)

This works in 3.0 idraw exactly as you describe.
--
John Vlissides
Computer Systems Lab
Stanford University
vlis@interviews.stanford.edu


--
John Interrante / interran@lurch.stanford.edu

vlis@lurch.stanford.edu (John Vlissides) (05/07/91)

In article <9105030745.AA16756@adagio.chorus.fr> dp@chorus.fr (Didier Poirot) writes:
   | John Vlissides archived his fix for the 8-bit character problem in
   | ~ftp/pub/3.0-fixes/fix2 on interviews.stanford.edu.  For people's
   | convenience, I'll enclose the contents of fix2 in this message.
   | -- 
   | 	Apply with ``patch -p -N < fix2'' at the top of the source tree.


   thanks for this patch. But if one bug is corrected, it seems that one other
   is still there. 

   After applying fix-2 and fix-3, I play with idraw, and specially 8 bit chars.
   All feel good, execpt that once a file (with 8 bits chats) has been saved, 
   idraw can't re-read it correctly, and it displays bullets in place of 
   the 8 bits chars.

The patch below is archived as fix4 in the 3.0-fixes directory on
interviews.stanford.edu.

        Apply with ``patch -p -N < fix4'' at the top of the source tree.

*** /tmp/,RCSt1a28750	Tue May  7 10:50:33 1991
--- iv/src/bin/idraw/idcatalog.c	Sun May  5 19:04:33 1991
***************
*** 966,972 ****
  			in.get(buf[1]);
  			in.get(buf[2]);
  			buf[3] = '\0';
! 			c = octal(_buf);
  		    }
  		}
  		dot += stext.Insert(dot, &c, 1);
--- 966,972 ----
  			in.get(buf[1]);
  			in.get(buf[2]);
  			buf[3] = '\0';
! 			c = octal(buf);
  		    }
  		}
  		dot += stext.Insert(dot, &c, 1);
--
John Vlissides
Computer Systems Lab
Stanford University
vlis@interviews.stanford.edu