[net.bugs.4bsd] bug in news/uurec.c

kre@munnari.SUN (Robert Elz) (01/06/84)

First, I apologise for posting this bug report to these groups,
but the group concerned with news does not reach Australia ....

uurec (the process that receives news sent in the mail via sendnews)
improperly handles From lines in two ways.

1. It expects any header line that starts 'From' to be a unix style
from line, mangling ARPA style 'From:' lines which do not generally
contain "remote from host" sections.

2. It loses the original senders full name from a From line in the
news item itself (of the form "From: person@host.domain (Full name)").

The diffs below correct these small faults, if you receive any news
via uurec, you should probably apply them.  These apply to news 2.10.1
(as distributed with 4.2bsd), but will probably apply to any other
version of news.

					Robert Elz
					decvax!mulga!kre

104c104
< 					sscanf(buf, "%s %s", fbuf, fbuf);
---
> 					sscanf(buf, "%s %[^\n]", fbuf, fbuf);
133c133
< 	if (strncmp(p, ">From", 5) == 0)
---
> 	if (strncmp(p, ">From ", 6) == 0)
136c136
< 	if (strncmp(p, "From", 4) == 0)
---
> 	if (strncmp(p, "From ", 5) == 0)