[alt.sys.sun] warning in compiling sunKbd.c in SunOS 4.1 make world

pjs@aristotle.JPL.NASA.gov (Peter Scott) (10/08/90)

I just did a make world of the X11R4.18 tree under SunOS 4.1,
and checked for errors and warnings.  The only ones were:

"sunKbd.c", line 170: warning: constant 770 is out of range of unsigned
 char comparison
"sunKbd.c", line 170: warning: result of comparison is always true

The line in mit/server/ddx/sun/sunKbd.c is:

               if (key.kio_entry != HOLE)

and it comes from the include file /usr/include/sundev/kbd.h,
which is included by sun.h in mit/server/ddx/sun.

On a SunOS 4.0.3 system, this is defined as:

/usr/include/sundev/kbd.h:#define       HOLE            0xA2    /* This key
 does not exist on the keyboard.

On the SunOS 4.1 system, it is defined as:

/usr/include/sundev/kbd.h:#define       HOLE            0x302   /* This key
 does not exist on the keyboard.

I still have a lot more work to do to get the installation complete, but
this (obviously) bothers me.  I have no clue what to do about it.  Any
information on the topic would be helpful.

-- 
This is news.  This is your       |    Peter Scott, NASA/JPL/Caltech
brain on news.  Any questions?    |    (pjs@aristotle.jpl.nasa.gov)