[comp.mail.mush] Problems with Mush 6.5.6

alfie@cs.warwick.ac.uk (Nick Holloway) (10/25/89)

I have recently noticed that the "In-Reply-To:" header is produced twice on
messages that are replies.

The system Mushrc is the standard one hacked marginally - mainly
removing features I didn't like. In there I have
	set in_reply_to = "%n's message of %d."

In my own .mushrc I have edit_hdrs and autoedit set. When I edit the
message, there is only one "In-Reply-To:" header, but when the message
is sent, an extra one is added. Has anybody else seen this (and will
there be a cure in the next release?).

While I'm here - I wish there was the ability to tell mush to *always*
page, no matter what the length is. [Various reasons a) consistancy of
appearance - paged messages print from top down, unpaged scroll up
screen, b) no need to worry about dodgy control chars] Since I use
curses mode mainly, I can not set crt, and so what I do currently is
terribly hacky (bind keys to reset crt then rebind!). What would be
nice is say:
	set alwayspage

or something.

	Thanks for your time

--
In real life: Nick Holloway <alfie@cs.warwick.ac.uk>

schaefer@ogccse.ogc.edu (Barton E. Schaefer) (10/26/89)

In article <2010@diamond.warwick.ac.uk> alfie@cs.warwick.ac.uk (Nick Holloway) writes:
} I have recently noticed that the "In-Reply-To:" header is produced twice on
} messages that are replies.

This only happens when edit_hdrs is set.  Since there aren't going to
be any more "official" patches to 6.5, here's an unofficial description
of the fix.  Sorry, I don't have correct line numbers for this at the
moment (all my 6.5 sources are archived), so I can't make a real diff.

In mail.c, function add_headers(), look for something like

	if (for_editor || isoff(flags, EDIT_HDRS)) {
#ifdef PICKY_MAILER
	    if (i > 0)
#endif /* PICKY_MAILER */
	    (void) fprintf(files[i], "%sDate: %s\n",
		ison(flags, FORWARD) ? "Resent-" : "", rfc_date(date_str));
	    got_date = TRUE;
	}
	if (*in_reply_to)
	    fprintf(files[i], "In-Reply-To: %s\n", in_reply_to);

The fix is to move the "if (*in_reply_to)" clause inside the curly
brace immediately above it.

} While I'm here - I wish there was the ability to tell mush to *always*
} page, no matter what the length is.

Yes, that may eventually appear.
-- 
Bart Schaefer      "A Yellowbeard is never so dangerous as when he's dead."
                                              -- Graham Chapman, 1941-1989
CSNET / Internet                schaefer@cse.ogc.edu
UUCP                            ...{sequent,tektronix,verdix}!ogccse!schaefer

tneff@bfmny0.UU.NET (Tom Neff) (10/27/89)

*** mail.c.O	Tue Aug  8 14:49:58 1989
--- mail.c	Thu Oct 26 12:57:18 1989
***************
*** 1580,1588 ****
  	    fprintf(files[i], "%sDate: %s\n",
  		ison(flags, FORWARD) ? "Resent-" : "", rfc_date(date_str));
  	    got_date = TRUE;
  	}
- 	if (*in_reply_to)
- 	    fprintf(files[i], "In-Reply-To: %s\n", in_reply_to);
      }
      /* next print user's own message headers */
      if (for_editor || isoff(flags, EDIT_HDRS))
--- 1580,1588 ----
  	    fprintf(files[i], "%sDate: %s\n",
  		ison(flags, FORWARD) ? "Resent-" : "", rfc_date(date_str));
  	    got_date = TRUE;
+ 		if (*in_reply_to)
+ 			fprintf(files[i], "In-Reply-To: %s\n", in_reply_to);
  	}
      }
      /* next print user's own message headers */
      if (for_editor || isoff(flags, EDIT_HDRS))

-- 
"A man came into the the office one day and said he  \|/  Tom Neff
was a sailor.  We cured him of that." - Mark Twain,  -O-  tneff@bfmny0.UU.NET
on his days as a doctor's apprentice in California.  /|\  uunet!bfmny0!tneff