[comp.mail.mush] Bug generating To: list on replyall

jss%greeble@Sun.COM (Josh Sirota) (10/31/89)

There seems to be a bug in mushview (7.0.0 9/15/89) when generating the To:
line with replyall for long address lists.  I'm not actually sure what the
true cause is, but it happens to me a couple of times every week when I
reply to messages with long To: lists.

After much debugging, I discovered that if get_name_n_addr(), which is
supposed to get the first address out of a list and return a pointer to the
rest of the list, is given a string that begins with white space then it
barfs (technical term).  I couldn't find a reason why it should necessarily
expect a string that doesn't begin with white space, so I just skipped over
it at the beginning.  The fix follows.

If Dan or Bart is curious, the call to get_name_n_addr() that hands it
white space is from take_me_off(), which is called by do_mail() (line 205
in mail.c).  It's obvious why it leaves a space at the beginning of the
string.

Josh

----------------------------------------------------------------------------

*** addrs.c.orig	Mon Oct 30 17:03:06 1989
--- addrs.c	Mon Oct 30 16:53:29 1989
***************
*** 882,887 ****
--- 882,891 ----
      if (!str || !*str)
  	return NULL;
  
+     /* skip white space */
+     while (isspace(*str))
+ 	str++;
+ 
      /* first check to see if there's something to look for */
      if (!(p = any(str, ",(<\""))) {
  	/* no comma or indication of a quote character. Find a space and
--
Josh Sirota
Sun Microsystems, NSE group
INTERNET: jss@sun.com			UUCP: ...!sun!jss