sbanner1@uvicctr.UVic.CA.UUCP (S. John Banner) (02/28/90)
I just got arround to installing Mush 7, Patchlevel 4 on our Pyramid,
and the compiler had a small complaint, which I thought I ought to
mention. On line 35 of folders.c, is a the line:
} else if (!tempfile || !*tempfile) {
however on looking through the code, to fix the problem, I found that
tempfile is an array of char, and hence ``!tempfile'' must always be
false (and hence the reason for the error). So, I would suggest that
that portion of the test be removed from the comparason in the next
set of official patches (unless I am farther behind than I think I am,
and this has already been delt with...).
sjb.schaefer@ogicse.ogi.edu (Barton E. Schaefer) (03/01/90)
In article <929@uvicctr.UVic.CA.UUCP> sbanner1@uvicctr.UVic.CA.UUCP (S. John Banner) writes: } } I just got arround to installing Mush 7, Patchlevel 4 on our Pyramid, } and the compiler had a small complaint, which I thought I ought to } mention. On line 35 of folders.c, is a the line: } } } else if (!tempfile || !*tempfile) { } } however on looking through the code, to fix the problem, I found that } tempfile is an array of char, and hence ``!tempfile'' must always be } false (and hence the reason for the error). If it actually generated an *error* rather than a *warning*, you have a broken compiler. } So, I would suggest that } that portion of the test be removed from the comparason in the next } set of official patches (unless I am farther behind than I think I am, } and this has already been delt with...). I can't decide whether to remove this or not. Clearly, as it stands, it isn't *necessary* -- but it also doesn't affect the correctness of the code. If the test were removed, and later the declaration of "tempfile" should change to become a pointer (to a malloc'd array), the remaining test of !*tempfile would break. All in all, I think it's doing more good than harm, but the suggestion is taken under advisement. -- Bart Schaefer "February. The hangnail on the big toe of the year." -- Duffy schaefer@cse.ogi.edu (used to be cse.ogc.edu)