naftoli@alsys1.aecom.yu.edu (Robert Berlinger) (05/08/91)
I believe Mush 7.2.2 has a bug which causes outgoing From: headers to
not include the user's full name in the default case (i.e., relying on
the full name (gecos) field in the password file).
In init.c line 75,
if (realname && *realname) {
the *realname test is failing because earlier on line 55, a for loop
increments realname to point to the nul at the end of the string
for (p = buf; *realname; realname++)
Mush 7.1.1 did not have the second test and worked ok. I'm not sure
why the second test was added, but it either needs to be backed out or
the code changed to increment a temp variable rather than realname.
--
Robert N. Berlinger |Domain: naftoli@aecom.yu.edu
Manager of Networking and Systems |UUCP: ...uunet!alsys1!naftoli
Research Information Technology |CompuServe: 76067.1114@compuserve.com
Albert Einstein College of Medicine |AppleLink: D3913@applelink.apple.comnaftoli@alsys1.aecom.yu.edu (Robert Berlinger) (05/08/91)
A followup to my previous post... I perused the code in init.c a bit more and apparently realname is an automatic variable that is not initialized, and if you follow the logic through you'll find that it's possible to reach the if(realname && *realname) tests before the variable is set. This is sure to be bogus if realname doesn't happen to pick up a 0 (NULL) value off the stack (a likely possibility). I suggest that the code initialize realname to NULL by the declaration. This is in addition to the problem mentioned in my previous post. Enjoy. -- Robert N. Berlinger |Domain: naftoli@aecom.yu.edu Manager of Networking and Systems |UUCP: ...uunet!alsys1!naftoli Research Information Technology |CompuServe: 76067.1114@compuserve.com Albert Einstein College of Medicine |AppleLink: D3913@applelink.apple.com