[comp.soft-sys.andrew] Errors in "eq" key bindings

guy@auspex.auspex.com (Guy Harris) (10/24/89)

(BTW, my other postings pertain to the beta version of Andrew,
patchlevel 4, as does this one; sorry for not noting that.)

A couple of the keybindings for "eq" are arguably wrong:

	1) "eqview-copy" is bound to ^Q rather than <ESC>w; I'd expect
	   it to be bound to <ESC>w since it's a similar operation to
	   the "copy" function in e.g. "text".

	2) "eqview-delete-backward" is, probably, intended to be bound
	   to DEL (^?), but there's a backslash missing from a string
	   in the structure entry that so binds it.

*** eqvcmds.c.dist	Fri Sep 22 07:11:19 1989
--- eqvcmds.c	Tue Oct 17 13:28:12 1989
***************
*** 1164,1170 ****
  
      /* FRONT menu card */
      {"eqview-cut", "\027",0,NULL,0,0,eqview_Cut, "Cut~11"},
!     {"eqview-copy", "\021",0,NULL,0,0,eqview_Copy, "Copy~12"},
      {"eqview-paste", "\031",0,"Paste~10",0,0,eqview_Paste, "Paste~13"},
  
  /*    {"eqview-save", "\030\023",0,"Save~31",0,0,eqview_Save, "Save equation in default file."}, */
--- 1164,1170 ----
  
      /* FRONT menu card */
      {"eqview-cut", "\027",0,NULL,0,0,eqview_Cut, "Cut~11"},
!     {"eqview-copy", "\033w",0,NULL,0,0,eqview_Copy, "Copy~12"},
      {"eqview-paste", "\031",0,"Paste~10",0,0,eqview_Paste, "Paste~13"},
  
  /*    {"eqview-save", "\030\023",0,"Save~31",0,0,eqview_Save, "Save equation in default file."}, */
***************
*** 1191,1197 ****
      /* Other commands */
      {"eqview-delete-forward", "\004",0,NULL,0,0,eqview_DeleteForward, "Delete forward from cursor."},
      {"eqview-delete-backward", "\010",0,NULL,0,0,eqview_DeleteBackward, "Delete backward from cursor."},
!     {"eqview-delete-backward", "177",0},
      /*{"eqview-undelete", "\025",0,NULL,0,0,eqview_UnDelete, "Undelete."}, */
  
      {"eqview-left-brace", "{",0,NULL,0,0,eqview_lbrace, "Insert a left brace."},
--- 1191,1197 ----
      /* Other commands */
      {"eqview-delete-forward", "\004",0,NULL,0,0,eqview_DeleteForward, "Delete forward from cursor."},
      {"eqview-delete-backward", "\010",0,NULL,0,0,eqview_DeleteBackward, "Delete backward from cursor."},
!     {"eqview-delete-backward", "\177",0},
      /*{"eqview-undelete", "\025",0,NULL,0,0,eqview_UnDelete, "Undelete."}, */
  
      {"eqview-left-brace", "{",0,NULL,0,0,eqview_lbrace, "Insert a left brace."},

maria+@ANDREW.CMU.EDU ("Maria G. Wadlow") (10/25/89)

Thanks for the bug reports, I will be checking in a few changes to the
eq code and I will look at these problems as well.

				Maria
-----------------------------------

Maria G. Wadlow
maria+@andrew.cmu.edu

Human Factors Group
Information Technology Center
Carnegie Mellon University
4910 Forbes Avenue
Pittsburgh, PA  15213-3890  USA
(412) 268 - 6794
(412) 268 - 6787 (fax)