mike@ETL.ARMY.MIL (Mike McDonnell) (05/28/89)
Here are some bugs. The third one is probably the most serious. 1. For the toplevel Makefile, the lines ================================================================== etc: libg++.a (cd etc; make GXX="$(GXX)" CC="$CC" LIBDIR=$(LIBDIR)) gperf: libg++.a (cd gperf; make GXX="$(GXX)" CC="$CC" LIBDIR=$(LIBDIR)) ================================================================== should probably read ================================================================== etc: libg++.a (cd etc; make GXX="$(GXX)" CC="$(CC)" LIBDIR=$(LIBDIR)) gperf: libg++.a (cd gperf; make GXX="$(GXX)" CC="$(CC)" LIBDIR=$(LIBDIR)) ================================================================== since the CC expands to just "C" rather than "gcc" as it does for the second set of lines. This isn't used in either etc or gperf anyway, so maybe the CC bindings can just be removed. 2. In the Makefile for gperf, the unbound variable $(MAKE) just expands to nothing at all. The fix is to either set "MAKE = make" at the top of the file or replace all the "$(MAKE)" with a simple "make". 3. Instructions on how to run the tests are non-existent. The file names may now be "self explanatory" but I would still like an overview of what is going on in the tests. A README file in the tests directory might be nice. It might also be useful to have the comprehensive tests run by the Makefile in the tests directory with the output saved in a file (using tee perhaps) for ease of bug reports and analysis.