[gnu.utils.bug] Errors in binutils Makefile

pinard@EDDIE.MIT.EDU (Francois Pinard) (12/04/89)

I fetched binutils from prep.ai.mit.edu this morning.  The making was
done on a Sun-4 using make 3.57.  Here is an informal description of
the problems:

   1) Makefile symbol `bindir' should be defined, an invitation do to
      so should ideally appear at the beginning of the Makefile.

   2) In install target, the last $ should be doubled.

   3) In install target, the `cp' and the `mv' line should both have a
      semicolon before the continuation.

Here is a quick diff to illustrate these points a little:

---------------------------------------------------------------------->
*** Makefile~	Sun Dec  3 13:53:07 1989
--- Makefile	Sun Dec  3 14:19:28 1989
***************
*** 111,120 ****
  	compress < binutils.tar > binutils.tar.Z
  	rm -rf binutils
  
  .PHONY: install
  install: $(PROGS)
  	for file in $(PROGS); do \
! 	cp $$file $(bindir)/$${file}.new \
! 	mv $(bindir)/$${file}.new $(bindir)/$file \
  	done
  
--- 111,121 ----
  	compress < binutils.tar > binutils.tar.Z
  	rm -rf binutils
  
+ bindir	=../../gnu/bin
  .PHONY: install
  install: $(PROGS)
  	for file in $(PROGS); do \
! 	cp $$file $(bindir)/$${file}.new; \
! 	mv $(bindir)/$${file}.new $(bindir)/$$file; \
  	done
  
----------------------------------------------------------------------<

-- 
Franc,ois Pinard                                    pinard@iro.umontreal.ca
(514) 588-4656           ``Vivement GNU!''          ...!uunet!iros1!pinard