[gnu.emacs.gnus] bug

michel@es.ele.tue.nl (& Berkelaar) (06/30/89)

If found what I think is a bug in gnus-inews-message-id in gnus 3.12.

The message id is composed of a unique part and the domain name. However,
in calculating the domain name, gnus-inews-message-id does not consider
the variable gnus-use-generic-from, and hence may come up with a faulty domain.
This is probably not very problematic, but for the sake of uniformity, and in
order not to confuse users, I think the definition of gnus-inews-message-id
should be changed to the following:


(defun gnus-inews-message-id ()
  "Generate unique Message-ID for user."
  ;; Message-ID should not contain a slash and should be terminated by
  ;; a number.  I don't know the reason why it is so.
  (concat "<" (gnus-inews-unique-id) "@" 
	  (gnus-inews-domain-name gnus-use-generic-from) ">"))

--
-------------------------------------------------------------------------------
Michel Berkelaar                   | Email: michel@es.ele.tue.nl   (prefered)
Eindhoven University of Technology |        ..!mcvax!euteal!michel (old)
Dept. of Electrical Engineering    |
Design Automation Section          |
P.O. Box 513                       | Phone: ... - 31 - 40 - 473345
NL-5600 MB Eindhoven               | Fax:   ... - 31 - 40 - 448375
The Netherlands                    |
-------------------------------------------------------------------------------

wisner@mica.Berkeley.EDU (Bill Wisner) (07/03/89)

The way GNUS generates message-IDs is correct.

Message-IDs must be absolutely unique. When GNUS uses your true local
hostname, this can be easily arranged. It is more problematic when several
machines all use the same hostname in message-IDs.

It is also rather nice to be able to see from which machine someone is
actually posting. (My address is wisner@mica.berkeley.edu, but I never
actually log in to mica.)

You said that "in order not to confuse users" the IDs generated by GNUS
should use gnus-use-generic-from. The message-ID field is not intended
for users to use; it is intended for software. In GNUS, a user never even
sees message-IDs unless he specifically asks for them. So why does it
bother you?

Bill Wisner		wisner@mica.berkeley.edu	     ucbvax!mica!wisner
I'm not the NRA either.

ambar@bloom-beacon.mit.edu (Jean Marie Diaz) (07/04/89)

   From: wisner@mica.Berkeley.EDU (Bill Wisner)
   Date: 2 Jul 89 19:19:19 GMT

   You said that "in order not to confuse users" the IDs generated by GNUS
   should use gnus-use-generic-from. The message-ID field is not intended
   for users to use; it is intended for software. In GNUS, a user never even
   sees message-IDs unless he specifically asks for them. So why does it
   bother you?

Because under some circumstances, GNUS will ask the user for the domain
even if gnus-use-generic-from is set.  It still does the right thing,
but it is confusing.

				 AMBAR
ambar@bloom-beacon.mit.edu		   {mit-eddie,uunet}!bloom-beacon!ambar

shadow@pawl.rpi.edu (Deven T. Corzine) (07/06/89)

In article <WISNER.89Jul2121919@anableps.berkeley.edu> wisner@mica.Berkeley.EDU (Bill Wisner) writes:
>The way GNUS generates message-IDs is correct.

Pure opinion.  On which I disagree.

>Message-IDs must be absolutely unique. When GNUS uses your true local
>hostname, this can be easily arranged. It is more problematic when
>several machines all use the same hostname in message-IDs.

Why??  Do you find it likely that you will post two separate messages
from machines using the same hostname in the same second??  Get real.

>It is also rather nice to be able to see from which machine someone
>is actually posting. (My address is wisner@mica.berkeley.edu, but I
>never actually log in to mica.)

It uses the same domain as it uses for the "From:" line.  If you
posted as if from a different domain, (as I do) then the generated
hostname is the Message-ID is WRONG.  I finally added a hook to delete
the hostname from the domain in the Message-ID, in gnus-Inews-hook.
(or whatever it is) It should NOT use the host and domain for the
Message-ID if it uses only the domain for the From: line.  That is
inconsistent behavior.  And wrong.  (IMO)

>You said that "in order not to confuse users" the IDs generated by
>GNUS should use gnus-use-generic-from. The message-ID field is not
>intended for users to use; it is intended for software. In GNUS, a
>user never even sees message-IDs unless he specifically asks for
>them. So why does it bother you?

Users OFTEN see Message-ID's, particularly in attribution lines when
someone is quoted.  And yes, poorly generated ID's (and long ones) get
to be quite annoying.

Deven
--
shadow@[128.113.10.2]   <shadow@pawl.rpi.edu> Deven T. Corzine (518) 272-5847
shadow@[128.113.10.201] <shadow@acm.rpi.edu>  2346 15th St.    Pi-Rho America
deven@rpitsmts.bitnet   <userfxb6@rpitsmts>   Troy, NY 12180-2306  <<tionen>>
"Simple things should be simple and complex things should be possible." - A.K.

wisner@mica.Berkeley.EDU (Bill Wisner) (07/06/89)

shadow@pawl.rpi.edu (Deven T. Corzine) writes:

>Why??  Do you find it likely that you will post two separate messages
>from machines using the same hostname in the same second??  Get real.

Likely is too likely. Message-IDs must be *guaranteed* to be unique. Period.

>It uses the same domain as it uses for the "From:" line.

Only if you use gnus-your-domain. And if gnus-your-domain is set at all,
it should be set to your true hostname. If you put a dummy name in your
From line, use gnus-use-generic-from.

>                    It should NOT use the host and domain for the
>Message-ID if it uses only the domain for the From: line.  That is
>inconsistent behavior.  And wrong.  (IMO)

The From: line should contain a valid address at which you can receive
mail. The Message-ID line, in order to insure uniqueness, should contain
either the true hostname of your local machine, or the hostname of the
NNTP server that is posting your message.

>Users OFTEN see Message-ID's, particularly in attribution lines when
>someone is quoted.  And yes, poorly generated ID's (and long ones) get
>to be quite annoying.

I repeat: who bloody cares? Who sends mail to hostnames given in message
IDs? Their only purpose is to give each and every message a *unique*
identifier.

Bill Wisner		wisner@mica.berkeley.edu	     ucbvax!mica!wisner
I'm not the NRA either.