[gnu.emacs.gnus] bug in rnewspost.el

kamat@uceng.UC.EDU (Govind N. Kamat) (10/09/89)

At a few places in rnewspost.el, the news/mail buffer is narrowed
for the purpose of extracting information in the header fields.  This
information is then inserted into reply and followup buffers.

However, the buffer is narrowed one character too much; thus,
mail-fetch-field loses the trailing character if information in the
last field is to be extracted.  The patch at the bottom of this
article fixes this problem.

It takes care of the following effect noticed by Karl Kleinpaste while
using the GNUS newsreader: (I don't have the article number, sorry)

    From: Karl Kleinpaste <karl@cis.ohio-state.edu>
    Subject: Reading mail and news with a single GNUS

    [2] There is a bug in GNUS somewhere which I haven't been able to
    trace, where replying to a message via mail causes the trailing
    character of either the originator's address or the subject to be
    stripped off; this doesn't happen with real newsgroups, nor with all
    mail, so I suspect it's either POM-dependent or else it depends on
    some quirky header ordering which GNUS doesn't expect.  If anyone gets
    around to fixing this, please let me know.


*** /usr/local/emacs/lisp/rnewspost.el	Wed Jun 15 10:16:36 1988
--- rnewspost.el	Sat Sep 30 20:04:13 1989
***************
*** 252,258 ****
      (save-restriction
        (narrow-to-region (point-min) (progn (goto-line (point-min))
  					   (search-forward "\n\n")
! 					   (- (point) 2)))
        (setq from (mail-fetch-field "from")
  	    subject (mail-fetch-field "subject")
  	    reply-to (mail-fetch-field "reply-to")
--- 252,258 ----
      (save-restriction
        (narrow-to-region (point-min) (progn (goto-line (point-min))
  					   (search-forward "\n\n")
! 					   (- (point) 1)))
        (setq from (mail-fetch-field "from")
  	    subject (mail-fetch-field "subject")
  	    reply-to (mail-fetch-field "reply-to")
***************
*** 289,295 ****
  					;@@	but rnews.el lacks support
  		 (narrow-to-region (point-min) (progn (goto-char (point-min))
  						      (search-forward "\n\n")
! 						      (- (point) 2)))))
  	  (setq from (mail-fetch-field "from")
  		news-reply-yank-from from
  		;; @@ not handling old Title: field
--- 289,295 ----
  					;@@	but rnews.el lacks support
  		 (narrow-to-region (point-min) (progn (goto-char (point-min))
  						      (search-forward "\n\n")
! 						      (- (point) 1)))))
  	  (setq from (mail-fetch-field "from")
  		news-reply-yank-from from
  		;; @@ not handling old Title: field
***************
*** 365,371 ****
  					;@@	but rnews.el lacks support
  		 (narrow-to-region (point-min) (progn (goto-char (point-min))
  						      (search-forward "\n\n")
! 						      (- (point) 2)))))
  	  (setq news-reply-yank-from (mail-fetch-field "from")
  		;; @@ not handling old Article-I.D.: field
  		news-reply-yank-message-id (mail-fetch-field "message-id")))
--- 365,371 ----
  					;@@	but rnews.el lacks support
  		 (narrow-to-region (point-min) (progn (goto-char (point-min))
  						      (search-forward "\n\n")
! 						      (- (point) 1)))))
  	  (setq news-reply-yank-from (mail-fetch-field "from")
  		;; @@ not handling old Article-I.D.: field
  		news-reply-yank-message-id (mail-fetch-field "message-id")))


--
Govind N. Kamat 			College of Engineering
kamat@uceng.UC.EDU			University of Cincinnati
					Cincinnati, OH 45221, USA