[gnu.gcc.bug] a couple of gcc nits

hugh@CIS.OHIO-STATE.EDU (D. Hugh Redelmeier) (04/25/89)

This message refers to GCC 1.34.

In cccp.c, the routine grow_outbuf is declared to return an int, but
it does not, and it is always used as if it returned void.  So I
changed it to be so declared.  This required a similar change to the
macro check_expand.

In reload.c, routine find_reloads_address_1 is declared to return an
int, and the description describes its value.  Within the routine
itself, there are a couple of returns that don't specify a value.  I
have guessed at what the value should be, but I could be wrong.

Also in reload.c, the file-static routine forget_volatility is
#if'ed out, but a declaration of it is not.

Another thing that I noticed, but did not change, is that several
definitions of fatal() fail to declare the format parameter to be a
char *.

------- cccp.c -------
*** /tmp/da4056	Tue Apr 25 01:30:32 1989
--- cccp.c	Fri Apr 21 19:01:50 1989
***************
*** 100,106 ****
  void skip_if_group ();
  void output_line_command ();
  
! int grow_outbuf ();
  int handle_directive ();
  void memory_full ();
  
--- 100,106 ----
  void skip_if_group ();
  void output_line_command ();
  
! void grow_outbuf ();
  int handle_directive ();
  void memory_full ();
  
***************
*** 218,225 ****
     so it can hold at least NEEDED more chars.  */
  
  #define check_expand(OBUF, NEEDED)  \
!   (((OBUF)->length - ((OBUF)->bufp - (OBUF)->buf) <= (NEEDED))   \
!    ? grow_outbuf ((OBUF), (NEEDED)) : 0)
  
  struct directory_stack
    {
--- 218,225 ----
     so it can hold at least NEEDED more chars.  */
  
  #define check_expand(OBUF, NEEDED)  \
!   do if ((OBUF)->length - ((OBUF)->bufp - (OBUF)->buf) <= (NEEDED))   \
!      grow_outbuf ((OBUF), (NEEDED)); while (0)
  
  struct directory_stack
    {
***************
*** 4538,4544 ****
   * should work ok.
   */
  
! int
  grow_outbuf (obuf, needed)
       register FILE_BUF *obuf;
       register int needed;
--- 4538,4544 ----
   * should work ok.
   */
  
! void
  grow_outbuf (obuf, needed)
       register FILE_BUF *obuf;
       register int needed;

------- reload.c -------
*** /tmp/da4059	Tue Apr 25 01:30:51 1989
--- reload.c	Fri Apr 21 16:54:36 1989
***************
*** 187,193 ****
--- 187,195 ----
  static int find_reloads_address ();
  static int find_reloads_address_1 ();
  static int hard_reg_set_here_p ();
+ #if 0
  static rtx forget_volatility ();
+ #endif
  static rtx subst_reg_equivs ();
  static rtx subst_indexed_address ();
  rtx find_equiv_reg ();
***************
*** 2311,2320 ****
  	{
  	  if (REG_OK_FOR_INDEX_P (op0)
  	      && REG_OK_FOR_BASE_P (op1))
! 	    return;
  	  else if (REG_OK_FOR_INDEX_P (op1)
  	      && REG_OK_FOR_BASE_P (op0))
! 	    return;
  	  else if (REG_OK_FOR_BASE_P (op1))
  	    find_reloads_address_1 (op0, 1, &XEXP (x, 0));
  	  else if (REG_OK_FOR_BASE_P (op0))
--- 2313,2322 ----
  	{
  	  if (REG_OK_FOR_INDEX_P (op0)
  	      && REG_OK_FOR_BASE_P (op1))
! 	    return 0;
  	  else if (REG_OK_FOR_INDEX_P (op1)
  	      && REG_OK_FOR_BASE_P (op0))
! 	    return 0;
  	  else if (REG_OK_FOR_BASE_P (op1))
  	    find_reloads_address_1 (op0, 1, &XEXP (x, 0));
  	  else if (REG_OK_FOR_BASE_P (op0))

Hugh Redelmeier
{utcsri, yunexus, uunet!attcan!utzoo, hcr}!redvax!hugh or hugh@redvax.UUCP
When all else fails: hugh@csri.toronto.edu
+1 416 482-8253
[Note: it appears that some site is munging my address in the mail
header.  Your mailer's "reply" command may not work.]