[gnu.emacs.bug] setting breakpoints on subrs

hrp@snoid.cray.com (Hal Peterson) (12/06/88)

Following is a modified version of the 18.52 debug.el that makes it
possible to set debug-on-entry breakpoints on subrs.  I've tried it,
and it seems to work okay.  The debugger-save-subrs code is a hack
that I came up with because the first subr on which I wanted to set a
breakpoint was 'message; naturally I ended up in an infinite
recursion.  It's not perfect (try setting a breakpoint on 'mapcar, for
example), but it's handy.

This also fixes a bug present in the 18.52 debugger:  if the function
value of a symbol is another symbol, you couldn't set a breakpoint on
it.  Now you can.

--
Hal Peterson / Cray Research / 1440 Northland Dr. / Mendota Hts, MN  55120
hrp@cray.com			bungia!cray!hrp		    (612) 681-3145

============================================================
;; Debuggers and related commands for Emacs
;; Copyright (C) 1985, 1986 Free Software Foundation, Inc.

;; This file is part of GNU Emacs.

;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY.  No author or distributor
;; accepts responsibility to anyone for the consequences of using it
;; or for whether it serves any particular purpose or works at all,
;; unless he says so in writing.  Refer to the GNU Emacs General Public
;; License for full details.

;; Everyone is granted permission to copy, modify and redistribute
;; GNU Emacs, but only under the conditions described in the
;; GNU Emacs General Public License.   A copy of this license is
;; supposed to have been given to you along with GNU Emacs so you
;; can know your rights and responsibilities.  It should be in a
;; file named COPYING.  Among other things, the copyright notice
;; and this notice must be preserved on all copies.


(setq debugger 'debug)

(defvar debugger-subr-alist nil
  "An alist of subrs with breakpoints set on them.  Associated with the
symbols for the subrs are the functions initially bound to them.  This is
useful for restoring the values later, and for temporarily restoring them
while trying to run the debugger itself without infinite recursions.")

; To minimize the chances of infinitely recursive debugger invocations,
; while the debugger is running we turn off subr breakpoints using the
; following function.
(defmacro debugger-save-subrs (&rest body)
  "Evaluate arguments in sequence and return the value of the last one.
All breakpoints on subrs are turned off during evaluation, then turned
back on when evaluation is complete."
  (list 'let
	'((recovery-alist (mapcar 'debugger-swap-subr debugger-subr-alist)))
	(list 'prog1
	      (cons 'progn
		    body)
	      '(mapcar 'debugger-swap-subr recovery-alist))))

(defun debugger-swap-subr (subr)
  "SUBR is a dotted pair; replace the function definition of the symbol
in the car with the value in the cdr.  Return another dotted pair whose
car is the symbol and whose cdr is the previous value of the function
definition."
  (let ((old-value (symbol-function (car subr))))
    (fset (car subr) (cdr subr))
    (cons (car subr) old-value)))

(defun debug (&rest debugger-args)
  "Enter debugger.  Returns if user says \"continue\".
Arguments are mainly for use when this is called
 from the internals of the evaluator.
You may call with no args, or you may
 pass nil as the first arg and any other args you like.
 In that case, the list of args after the first will 
 be printed into the backtrace buffer."
  (debugger-save-subrs
   (message "Entering debugger...")
   (let (debugger-value
	 (debugger-match-data (match-data))
	 (debug-on-error nil)
	 (debug-on-quit nil)
	 (debugger-buffer (let ((default-major-mode 'fundamental-mode))
			    (generate-new-buffer "*Backtrace*")))
	 (debugger-old-buffer (current-buffer))
	 (debugger-step-after-exit nil)
	 ;; Don't keep reading from an executing kbd macro!
	 (executing-macro nil)
	 (cursor-in-echo-area nil))
     (unwind-protect
	 (save-excursion
	   (save-window-excursion
	     (pop-to-buffer debugger-buffer)
	     (erase-buffer)
	     (let ((standard-output (current-buffer))
		   (print-escape-newlines t)
		   (print-length 50))
	       (backtrace))
	     (goto-char (point-min))
	     (debugger-mode)
	     (delete-region (point)
			    (progn
			      (forward-sexp 8)
			      (forward-line 1)
			      (point)))
	     (cond ((memq (car debugger-args) '(lambda debug))
		    (insert "Entering:\n")
		    (if (eq (car debugger-args) 'debug)
			(progn
			  (backtrace-debug 4 t)
			  (delete-char 1)
			  (insert ?*)
			  (beginning-of-line))))
		   ((eq (car debugger-args) 'exit)
		    (insert "Return value: ")
		    (setq debugger-value (nth 1 debugger-args))
		    (prin1 debugger-value (current-buffer))
		    (insert ?\n)
		    (delete-char 1)
		    (insert ? )
		    (beginning-of-line))
		   ((eq (car debugger-args) 'error)
		    (insert "Signalling: ")
		    (prin1 (nth 1 debugger-args) (current-buffer))
		    (insert ?\n))
		   ((eq (car debugger-args) t)
		    (insert "Beginning evaluation of function call form:\n"))
		   (t
		    (prin1 (if (eq (car debugger-args) 'nil)
			       (cdr debugger-args) debugger-args)
			   (current-buffer))
		    (insert ?\n)))
	     (message "")
	     (let ((inhibit-trace t)
		   (standard-output nil)
		   (buffer-read-only t))
	       (message "")
	       (recursive-edit))))
       ;; So that users do not try to execute debugger commands
       ;;  in an invalid context
       (kill-buffer debugger-buffer)
       (catch 'foo
	 (let ((d debugger-match-data))
	   (while d
	     (and (car d)
		  (null (marker-buffer (car d)))
		  ;; match-data buffer is deleted.
		  (throw 'foo nil))
	     (setq d (cdr d)))
	   (store-match-data debugger-match-data))))
     (setq debug-on-next-call debugger-step-after-exit)
     debugger-value)))

(defun debugger-step-through ()
  "Proceed, stepping through subexpressions of this expression.
Enter another debugger on next entry to eval, apply or funcall."
  (interactive)
  (debugger-save-subrs
   (setq debugger-step-after-exit t)
   (message "Proceding, will debug on next eval or call.")
   (exit-recursive-edit)))

(defun debugger-continue ()
  "Continue, evaluating this expression without stopping."
  (interactive)
  (debugger-save-subrs
   (message "Continuing.")
   (exit-recursive-edit)))

(defun debugger-return-value (val)
  "Continue, specifying value to return.
This is only useful when the value returned from the debugger
will be used, such as in a debug on exit from a frame."
  (interactive "XReturn value (evaluated): ")
  (debugger-save-subrs
   (setq debugger-value val)
   (princ "Returning " t)
   (prin1 debugger-value)
   (exit-recursive-edit)))

(defun debugger-frame-number ()
  "Return number of frames in backtrace before the one point points at."
  (save-excursion
    (beginning-of-line)
    (let ((opoint (point))
	  (count 0))
      (goto-char (point-min))
      (if (or (equal (buffer-substring (point) (+ (point) 6))
		     "Signal")
	      (equal (buffer-substring (point) (+ (point) 6))
		     "Return"))
	  (progn
	    (search-forward ":")
	    (forward-sexp 1)))
      (forward-line 1)
      (while (progn
	       (forward-char 2)
	       (if (= (following-char) ?\()
		   (forward-sexp 1)
		 (forward-sexp 2))
	       (forward-line 1)
	       (<= (point) opoint))
	(setq count (1+ count)))
      count)))

;; Chosen empirically to account for all the frames
;; that will exist when debugger-frame is called
;; within the first one that appears in the backtrace buffer.
;; Assumes debugger-frame is called from a key;
;; will be wrong if it is called with Meta-x.
(defconst debugger-frame-offset 8 "")

(defun debugger-frame ()
  "Request entry to debugger when this frame exits.
Applies to the frame whose line point is on in the backtrace."
  (interactive)
  (debugger-save-subrs
   (beginning-of-line)
   (let ((level (debugger-frame-number)))
     (backtrace-debug (+ level debugger-frame-offset) t))
   (if (= (following-char) ? )
       (let ((buffer-read-only nil))
	 (delete-char 1)
	 (insert ?*)))
   (beginning-of-line)))

(defun debugger-frame-clear ()
  "Do not enter to debugger when this frame exits.
Applies to the frame whose line point is on in the backtrace."
  (interactive)
  (debugger-save-subrs
   (beginning-of-line)
   (let ((level (debugger-frame-number)))
     (backtrace-debug (+ level debugger-frame-offset) nil))
   (if (= (following-char) ?*)
       (let ((buffer-read-only nil))
	 (delete-char 1)
	 (insert ? )))
   (beginning-of-line)))

(defun debugger-eval-expression (exp)
  (interactive "xEval: ")
  (debugger-save-subrs
   (save-excursion
     (if (null (buffer-name debugger-old-buffer))
	 ;; old buffer deleted
	 (setq debugger-old-buffer (current-buffer)))
     (set-buffer debugger-old-buffer)
     (eval-expression exp))))

(defvar debugger-mode-map nil)
(if debugger-mode-map
    nil
  (let ((loop ? ))
    (setq debugger-mode-map (make-keymap))
    (suppress-keymap debugger-mode-map)
    (define-key debugger-mode-map "-" 'negative-argument)
    (define-key debugger-mode-map "b" 'debugger-frame)
    (define-key debugger-mode-map "c" 'debugger-continue)
    (define-key debugger-mode-map "r" 'debugger-return-value)
    (define-key debugger-mode-map "u" 'debugger-frame-clear)
    (define-key debugger-mode-map "d" 'debugger-step-through)
    (define-key debugger-mode-map "h" 'describe-mode)
    (define-key debugger-mode-map "q" 'top-level)
    (define-key debugger-mode-map "e" 'debugger-eval-expression)
    (define-key debugger-mode-map " " 'next-line)))

(put 'debugger-mode 'mode-class 'special)

(defun debugger-mode ()
  "Mode for backtrace buffers, selected in debugger.
\\{debugger-mode-map}
For the r command, when in debugger due to frame being exited,
    the value specified here will be used as the value of that frame.

Note lines starting with * are frames that will
 enter debugger when exited."
  (debugger-save-subrs
   (kill-all-local-variables)
   (setq major-mode 'debugger-mode)
   (setq mode-name "Debugger")
   (setq truncate-lines t)
   (set-syntax-table emacs-lisp-mode-syntax-table)
   (use-local-map debugger-mode-map)))

(defun debug-on-entry (function)
  "Request FUNCTION to invoke debugger each time it is called.
If the user continues, FUNCTION's execution proceeds.
Works by modifying the definition of FUNCTION.
Use `cancel-debug-on-entry' to cancel the effect of this command.
Redefining FUNCTION also does that."
  (interactive "aDebug on entry (to function): ")
  (debugger-save-subrs
   (let ((defn (symbol-function function)))
     (while (symbolp defn) (setq defn (symbol-function defn)))
     (cond ((listp defn)
	    (if (eq (car defn) 'macro)
		(fset function
		      (cons 'macro
			    (debug-on-lisp-entry function (cdr defn) t)))
	      (fset function
		    (debug-on-lisp-entry function defn t))))
	   ((subrp defn)
	    (fset function
		  (debug-on-subr-entry function defn)))
	   (t (error "Function %s is neither Lisp function nor C subr."
		     function)))))
  function)

(defun cancel-debug-on-entry (function)
  "Undoes effect of debug-on-entry on FUNCTION."
  (interactive "aCancel debug on entry (to function): ")
  (let ((defn (symbol-function function))
	(subr (assoc function debugger-subr-alist)))
    (if subr
	(prog1 (fset function (cdr subr))
	  (setq debugger-subr-alist (delq subr debugger-subr-alist)))
      (if (eq (car defn) 'macro)
	  (fset function
		(cons 'macro
		      (debug-on-lisp-entry function (cdr defn) nil)))
	(fset function
	      (debug-on-lisp-entry function defn nil)))))
  function)

(defun debug-on-lisp-entry (function defn flag)
  "Set debugging on entry for FUNCTION whose value is DEFN; if FLAG is nil,
turn debugging off, otherwise turn it on."
  (or (eq (car defn) 'lambda)
      (error "%s not user-defined Lisp function." function))
  (let (tail prec)
    (if (stringp (car (nthcdr 2 defn)))
	(setq tail (nthcdr 3 defn)
	      prec (list (car defn) (car (cdr defn)) (car (cdr (cdr defn)))))
      (setq tail (nthcdr 2 defn)
	    prec (list (car defn) (car (cdr defn)))))
    (if (eq flag (equal (car tail) '(debug 'debug)))
	nil
      (if flag
	  (nconc prec (cons '(debug 'debug) tail))
	(nconc prec (cdr tail))))))

(defun debug-on-subr-entry (subr defn)
  "Set SUBR (whose definition is DEFN) to invoke the debugger on entry.
This is done by wrapping the subr call in a Lisp expression.  The subr
and its original definition are recorded in debugger-subr-alist for
future use."
  (setq debugger-subr-alist
	(cons (cons subr defn)
	      debugger-subr-alist))
  (fset subr
	(list 'lambda
	      '(&rest args)
	      '(debug 'debug)
	      (list 'apply defn 'args))))