enami@ptgd.sony.junet (enami tsugutomo) (07/17/89)
In GNU Emacs 18.54.3 of Fri May 12 1989 on chihaya (news-os) I found some bugs in GNU Emacs 18.54. They are not so serious. (Almost of them are left from 18.50 or before :-) * ftp-setup-buffer (ftp.el): Calling (fundamental-mode) kills local variables. So ftp-temp-file-name is reset to NIL and temporary file for ftp-write-file is never deleted. * ftp-sentinel (ftp.el): After (ftp-write-file), another buffer is set to read-only. Because: In first `let' of ftp-sentinel, we bind `buffer-read-only' to nil and in the body of same `let', we kill the current-buffer. So, when unbind, the value of buffer-local-variable `buffer-read-only' is restored to wrong buffer. * buffer.c X: DEFUN ("list-buffers", Flist_buffers, Slist_buffers, 0, 1, "", O: DEFUN ("list-buffers", Flist_buffers, Slist_buffers, 0, 1, "P", * Finsert_char() (editfns.c): Actually if (n < 0) -> if (n <= 0) and strlen = max (n, 256); -> strlen = min (n, 256); , isn't it ? * Fload() (lread.c): FILE* is stored in malloced area but the area from it is never freed. So at least we must call free (XPNTR(stream)); in load_unwind(). But, is malloc'ing really needed ? * count_blanks() (dispnew.c): Why variable declared as register is not used in loop? Or want to write like this ?: while (*p++ == ' '); return p - str - 1; * Fcall_process_region (callproc.c): I think It is better to unwind-protect to unlink temporary file. Thanks. -- Development division, Production Technology Group, Sony Corp. Tsugutomo Enami enami%ptgd.sony.junet@uunet.uu.net