akcs.falco@hpcvbbs.UUCP (Andrey Dolgachev) (03/21/91)
Hello all, I'm afraid that a small bug has been found by Joe Ervin. If
you enable the NExt pieve function by pressing N, and then disable it by
pressing N, the last piece displayed remains in the window. It's very
simple to fix, so I'll just post the fix here.
First of all, VISIT RK2, which is the last variable in the 6th row,
unless you changed the order. First, put a << in the very begginning.
Then, go to the program in the list which starts with 7 FC?C. CHANGE
\<< 7 FC?C
IF
THEN
7 SF SHNP
ELSE PICT {
# 20H # 1Bh } CPC
REPL
END \>>
After the REPL, add the following
ELSE PICT { # 20h #1Bh } CPC REPL
put it before END and after REPL.
Now, put \>> at the very end of the program. O.K>, that's it, press
ENTER and then it's all right.
Later all,
-------Falcoakcs.falco@hpcvbbs.UUCP (Andrey Dolgachev) (03/21/91)
Whoops, the section that I said change is what it should like after the
change. So that section of code I gave you, that's what it should like
after you add the ELSE PICT {..} CPC REPL.
---Falcoervin@pinbot.enet.dec.com (Joseph James Ervin) (03/21/91)
Thanks Andrey,
It probably doesn't make sense to release a new version just to fix this
problem. It might, however, be good to upload the modified routine in
ASC format when it's convenient. Then when people start requesting
reposts in a few weeks, the reposted version 2.1 should include this
fix.
I have one thing I would like to see in the next release. I hate it
when the game ends and I don't have any idea what my score was because I
didn't make it to the top 5. Would it be possible to return the score
to the stack when the game ends? Maybe the score in level 2 and the
number of rows completed in level 1.
>>>Joe jmunkki@hila.hut.fi (Juri Munkki) (03/23/91)
I'm sorry, but I'm getting a little tired with all these oops messages about tetris. It's perfectly fine to post things now and then, but you have to remember that this is a worldwide group. I would very much appreciate it, if hpcvbbs users first tried their software on local users for a week or two and then posted the software to usenet. Just imagine 10000 HP48 users downloading all these versions and installing all these patches. I gave up a long time a ago. I haven't followed this thread enough to learn if HP48 tetris now correctly calculates the scores, but if it still doesn't you might be able to learn something from either rec.games.video or rec.games.programmer (I think it was rec.games.programmer). They are debating about the correct scoring system and it seems they are getting very close to the real system. ____________________________________________________________________________ / Juri Munkki / Helsinki University of Technology / Wind / Project / / jmunkki@hut.fi / Computing Center Macintosh Support / Surf / STORM / ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
akcs.falco@hpcvbbs.UUCP (Andrey Dolgachev) (03/25/91)
Hey, Juri, I'm sorry that all of the bugs haven't been worked out of
Tetris yet. And there's definitely no excuse for me not including
everything that everyone wants for Tetris in the one version that I post.
I guess it is stupid to post a new version as sson as I complete a number
of new features. Instead, I should wait a couple of years until I get
everything possible into Tetris and then post that version. As for
fixing bugs, I guess I should let the other, many, numerous HP48 users in
my community test it. After all, there's , let's see, Dave, and, hmm,
uh, gee, I guess that's it. Well, I'm sure that the two of us would
discover all the bugs with Tetris pretty fast, and definitely within the
two-years mark. Of course I could post Tetris on HP.programs or maybe in
usr.programs or User.form. I am sure that I would get many responses
about bugs or new version ideas there. Maybe even one message a month.!
Thanks for your inpout, Juri.
--Falcoakcs.joehorn@hpcvbbs.UUCP (Joseph K. Horn) (03/25/91)
Andrey and Juri: The point of only posting fully debugged versions of Tetris would be moot if HP had lsitened to others' requests that only a fully debugged version of the HP 48SX be released. In that case, we'd have no versions of the 48 or Tetris to play with. Andrey: When I write good code, it gives a certain satisfaction, but I learn nothing from it. It's only when a bug creeps in, that I learn; the hunt is on, and clever new debugging techniques must be invented. I have learned a lot from your programs, and from the postings about the bugs, and from their corrections. Keep up the good work. And as for the mind-sucking aliens from planet Zok who only feast on Pure Thought and don't want our normal, average, still-learning minds... they can surely find their food on some philosophy or religious bbs. -- Joseph K. Horn -- Peripheral Vision, Ltd. --
akcs.falco@hpcvbbs.UUCP (Andrey Dolgachev) (03/26/91)
Thanks, Joe. And on the notes of bugs, a couple more have been
discovered. Nothing serious, but.. As a result, I will prob. end up
posting Tetris2.2 pretty soon. I guess that Joe's positive thinking
would work in this case, I am learning with each bug, but I sometimes
wish that I wasn't learning that much.
--Falcokenw@col.hp.com (Ken Wyatt) (03/27/91)
Nice program Andrey. One thing I might note (as long as you are still adding improvements!) is that the clock flag needs to be reset for both the "ABOUT" and "START" programs, so the clock display doesn't upset the game screens. Also in the "START" program, I set the mode to STD so numeric data without decimals was used during play. Just two less things for me to remember to do prior to startup. Regards...
231b3618@fergvax.unl.edu (Ben Hollingsworth) (03/28/91)
Falco,
Where can I get the source for your version of Tetris 2.1?
(Not that I need another version!)
-- Obi-Wan
|\_/|
\'o.0'/ AACK! PTHAT!
=(___)=
Uakcs.falco@hpcvbbs.UUCP (Andrey Dolgachev) (03/30/91)
First of all, Tetris 3.0 is due out any day now. I finished it
essentially and I am working on making sure everything is nice and clean
and bug-free.
To Ken Wyatt: I've added a few things like aking sure that the clock
doesn't turn on, and the STD has been in Tetris since v. 2 I believe.
Thanks for your help, though, I think that I've gotten almost all the
bugs occuring from flags set wrong out.
To Obi-Wan: I will post Tetris3.0 up in a day or so on c.s.h and I think
that I can now get on the ftp sites and u/l it.
---Falcoakcs.falco@hpcvbbs.UUCP (Andrey Dolgachev) (04/03/91)
Thomas,
Tetris has not gotten slower as new features have been added on. At
least the actual game itself, the falling pieves and such has not gotten
significantly or even noticeably slower. This is because all the
additionas and new features take place before you start playing, when you
first start up, and after you're done playing. When talking about the
speed, I assume that you are talking about the actual game, and not the
pause before the screen is created, or the pause before the high scores
are created and drawn up. When I worked on all the additions, I made
sure that the speed stayed the same. The speed comes about as a result
of the main loop which controls the falling of the pieces, the rotation,
movement, dissapeareance of lines, etc. The addition I made to this main
loop is the drawing of the Next Piece. The drawing only happens when the
pieve first appears at the top, and this takes as much time as it takes
to put a piece up on the screen, or in other words, it's barely
noticeable. And you can always start on Level 9, with the Next off, and
it'll be as fast as the old version.
Unfortuanately, the main loop is pretty small and efficent now,
thanks to Erik's original ML routines. It looks like even Tetras would
not be that much faster, unless someone came up up with some really neat
code.
----Falcoakcs.falco@hpcvbbs.UUCP (Andrey Dolgachev) (04/06/91)
Yaniv, check out my recent posting on the matter of the slower bug
(simply go to delay and put a DROP after the INCR command)
---Falco
BTW Tetris is faster now, especially with the drop command