[comp.sources.games.bugs] --- Conquer: non-square board bug

fortin@zap.UUCP (Denis Fortin) (02/20/88)

In article <1427@bucsb.UUCP>, adb@bucsb.UUCP (Adam Bryant) writes:
> In article <5030@tut.cis.ohio-state.edu> stucki@perch.cis.ohio-state.edu (David J. Stucki) writes:
> >
> >Here is the latest bug in (Barlow's) conquest I found that I haven't
> >seen reported elsewhere.
> >
> >Well, it appears that there are several places (10 to 15) where a reference
> >to MAPX is made when it should be MAPY. [...]
> 
> this also occurs within the recent conquer distribution as well, 

A simple grep on the conquer directory detected the following offending lines:

 combat.c:	for(i=0;i<MAPX;i++) for(j=0;j<MAPX;j++) occ[i][j]=0;
 makeworld.c:				if(i>=0&&j>=0&&i<MAPX&&j<MAPX)
 move.c:	for(x=0;x<MAPX;x++) for(y=0;y<MAPX;y++){
 reports.c:	for(xsctr=0;xsctr<MAPX;xsctr++) for(ysctr=0;ysctr<MAPX;ysctr++) if(sct[xsctr][ysctr].owner==country) {
 reports.c:	for(xsctr=0;xsctr<MAPX;xsctr++) for(ysctr=0;ysctr<MAPX;ysctr++) if(sct[xsctr][ysctr].owner==country) {

In each of these cases, the second MAPX should be replaced by MAPY.

There may be others (I only checked for double occurences of `MAPX' in a line).
-- 
Denis Fortin                            | fortin@zap.UUCP
CAE Electronics Ltd                     | philabs!micomvax!zap!fortin
The opinions expressed above are my own | fortin%zap.uucp@uunet.uu.net