[comp.sources.games.bugs] Some Conquer 4.6 bugs

jrk@sys.uea.ac.uk (Richard Kennaway) (10/10/89)

I tried to send these to adb@bu-cs.bu.edu, but it bounced.  Well, other
people will probably want to see these, so I might as well post here.
These are not official conquer patches.

1.  When fleets are merged, the resulting fleet gets the maximum of the
move points of the component fleets.  It should get the minimum.

Fix to reports.c:
647c647
< 					if(P_NMOVE>curntn->nvy[newnavy].smove)
---
> 					if(P_NMOVE<curntn->nvy[newnavy].smove)


2.  Cost to buy attack bonus can be negative because of overflow.
Fix: use the same trick used in computing cost of defense bonus, viz.:

forms.c
633,634c633,634
< 		armynum = max( curntn->aplus-intval, 10 );
< 		cost = METALORE*men*armynum*armynum/100;
---
> 		armynum = max( curntn->aplus-intval, 10 ) / 10;
> 		cost=METALORE*men*armynum*armynum;


3.  If a player does not move, conquer sends a message of the form
"The computer moved for you in the theed of year 119534".
Fix to update.c:
579c579
< 				fprintf(fm,"The computer moved for you in the %s of Year %d\n",curntn->name,PSEASON(TURN),YEAR(TURN));
---
> 				fprintf(fm,"The computer moved for you in the %s of Year %d\n",PSEASON(TURN),YEAR(TURN));


4.  Some of the messages from conquer have a trailing comma, e.g. "new
architect strengthens castle walls,"

Fix to randeven.c:
909c909
< 		fprintf(fm,"%s during the %s of Year %d,\n",event,PSEASON(TURN),YEAR(TURN));
---
> 		fprintf(fm,"%s during the %s of Year %d",event,PSEASON(TURN),YEAR(TURN));
911c911,912
< 		fprintf(fm," centered around location %d, %d.\n",xloc,yloc);
---
> 			fprintf(fm,",\ncentered around location %d, %d",xloc,yloc);
> 		fprintf(fm,".\n");


5.  A couple of other message formatting errors in update.c:
876c876
< 							fprintf(fm,"\tYour Scouting Unit %d was captured\n");
---
> 							fprintf(fm,"\tYour Scouting Unit was captured\n");
1442,1443c1442,1443
< 					fprintf(fm,"Gold imbalance forced your treasury to purchase");
< 					fprintf(fm,"%ld jewels for %ld gold talons to compensate\n",
---
> 					fprintf(fm,"Gold imbalance forced your treasury to purchase\n");
> 					fprintf(fm,"%ld jewels for %ld gold talons to compensate.\n",


6.  If you use the H,J,K,L,Y, or U commands to move the cursor about
half a screen, and the cursor hits the edge of the world, the map is not
redrawn properly.  (Control-L gets it redrawn properly.)  I havent fixed
this.


7.  Lastly, another bug which I havent fixed: there is a limit on how
much fortification one can build at a given town or city, but this is
only enforced at the update, the user interface lets you spend a fortune
on fortification points that will vanish at the update.  The user should
instead get a message, e.g. "The city is already as impregnable as it
can be!<beep>"
    I also note that in data.h, the fortress component of the sector
info is said to be in the range 0..9, but in check.c, the maximum is 12.

--
Richard Kennaway          SYS, University of East Anglia, Norwich, U.K.
Janet:  kennaway@sys.uea.ac.uk		uucp:  ...mcvax!ukc!uea-sys!jrk

blackwol@pawl.rpi.edu (Larry F. Shields) (10/13/89)

      Greetings, I just recently got the game Conquer from an FTP, and 
have got it running...unfortunately, some things dont work to well. Okay, 
well that is what patches are for...But I only have this one most recently
printed.  Is there anyway that you wonderful people out there in Net land
can send me an address where old patches for this game are archived?  Or 
maybe even, dare I ask, send me the old patches?  (I just know I am gonna
regret that). But, just an address that will allow me to anonymously FTP
in will do.  My thanks to all...


-- 
*******************************************************************************
  "So, when you go into the cafeteria      *    Larry Shields
   what you're smelling is food, and       *    Blackwolf
   that thing is a burger" - Bob McKenzie  *    blackwol@pawl.rpi.edu

blackwol@pawl.rpi.edu (Larry F. Shields) (10/13/89)

        Ooops.  I just realized, not only do I not have patches, I just
looked down and noticed that I am running Version 1.0!!!!  Ack!  This is
the ONLY copy of the game that I can find...Now I am even in worse shape, 
but I will ask anyway.  I am hooked even after only seeing this simple verion.
Please, please good people, how can I get a copy of the newest version???
I am assuming they are up to 4.6 now...(Gads...Version 1?) so mail as to 
where I can get it would be wonderful.  I need it to run for a Sun 3/50...
We use Sunview, but it is close enough that a BSD verion will work just 
fine.  You will have the gratitude of a Conquest junkies thanx...

 
-- 
*******************************************************************************
  "So, when you go into the cafeteria      *    Larry Shields
   what you're smelling is food, and       *    Blackwolf
   that thing is a burger" - Bob McKenzie  *    blackwol@pawl.rpi.edu