[comp.sources.games.bugs] adl2 - only a bug if you change things

dg@pallio.UUCP (David Goodenough) (06/27/90)

There is a potential bug in scen.c, in the procedure pphr() - it starts
at about line 387 in scen.c The way it's delivered, it looks like this:

pphr()
 {
    int i;
    struct _phrase_ *phrp;
    char *bp;

    if (phrnum >= MAXMOVE)
     {
	printf("To many 'p' records\n");
	return;
     }

etc. etc.

It should be this:

pphr()
 {
    int i;
    struct _phrase_ *phrp;
    char *bp;

    if (phrnum >= MAXPHR)
     {
	printf("To many 'p' records\n");
	return;
     }

This won't be an issue unless you start changing the stuff in game.h,
since as delivered MAXMOVE and MAXPHR are the same (75).
-- 
	dg@pallio.UUCP - David Goodenough		+---+
						IHS	| +-+-+
	..... !harvard!xait!pallio!dg			+-+-+ |
AKA:	dg%pallio.uucp@xait.xerox.com			  +---+

xanthian@zorch.SF-Bay.ORG (Kent Paul Dolan) (06/28/90)

In article <XX000117ed@pallio.UUCP> dg@pallio.UUCP (David Goodenough) writes:
>There is a potential bug in scen.c, in the procedure pphr() - it starts
>at about line 387 in scen.c The way it's delivered, it looks like this:
>
>pphr()
> {
>    int i;
>    struct _phrase_ *phrp;
>    char *bp;
>
>    if (phrnum >= MAXMOVE)
>     {
>	printf("To many 'p' records\n");
>	return;
>     }
>
>etc. etc.
>
>It should be this:
>
>pphr()
> {
>    int i;
>    struct _phrase_ *phrp;
>    char *bp;
>
>    if (phrnum >= MAXPHR)
>     {
>	printf("To many 'p' records\n");
>	return;
>     }
>
>This won't be an issue unless you start changing the stuff in game.h,
>since as delivered MAXMOVE and MAXPHR are the same (75).

While you're poking around in there, you might as well fix the
damned spelling too!


	printf("Too many 'p' records\n");

Kent, the man from xanth.
<xanthian@Zorch.SF-Bay.ORG> <xanthian@well.sf.ca.us>