[news.software.nntp] core dumps from nntpxmit

jerry@olivey.olivetti.com (Jerry Aguirre) (02/09/91)

I have just finished tracking down why my nntpxmit was causing core
dumps in the batch directory.  In nntpxmit.c the log function calls

		syslog(importance, error)

where error is the text message passed to log.  But the man page for
syslog says that the message may contain printf like escapes that
refference additional arguments.

Certain message IDs on the net have been including the "%" character as
part of the character radix used to encode the unique part.  If an error
message passed to "log" happens to include one of these message IDs, or
any percent character, then syslog will attempt to refference a
non-existent argument.

I suggest changing the entry to use:

		syslog(importance, "%s", error)

as there is no privision for "log" to pass additional arguments and no
mechanism to filter out the percent character in the text.

				Jerry Aguirre