[comp.mail.mh] problems with MH-POP

shore@adobe.COM (Andrew Shore) (04/12/88)

We are interested in using the POP (post office protocol) facilities in MH6.5.
I'm running under Sun Unix release 3.5.

I've turned on all the switches, and experimented a little.
It seems that the pop code still has some null pointer dereferencing problems.
Anyone running it on a VAX probably won't get these problems.

In particular, I set up a pop database file (/usr/spool/pop/POP)
with a stub subscriber entry as in the pop(5) man page:
	andy::andy:::::::0
And tried running popwrd.  After asking for the new password twice, 
popwrd dumps core with a segmentation fault (dbx on the core file reports):

strcmp(0x0, 0x20196) at 0xa1ec
main(argc = 2, argv = 0xefffd74, 0xefffd80), line 167 in "popwrd.c"

that code is:

165           fprintf (fp, ":%s:%s:", tail (bb -> bb_file), bb -> bb_passwd);
166           if ((ap = bb -> bb_leader) != NULL
167                   && (strcmp (*ap, POPUID) != 0 || ap[1] != NULL))

ap isn't NULL, but *ap is, hence strcmp fails.
(Looks like the code is based on some of the bboards code too.)

Rather than go in and start hacking each null dereference as I find
(in sequence), have any of you MH gurus out there already fixed this??
Is there something I have wrong in the pop database entry I started with?

Any fixes to the POP code would be appreciated.

Thanks in advance,
--Andy Shore
  {decwrl,sun}!adobe!shore OR adobe!shore@decwrl.dec.com OR shore@adobe.com