[comp.protocols.tcp-ip.ibmpc] Very Very Serious Bug in SOS!!!

stan@lbl-csam.arpa (See-Mong Tan) (03/24/89)

Greetings, I really really goofed this time (gawd, I'm embarassed).
After working on fixing the port mapper problem that Steve Nahm
pointed out, I discovered that the copy I had of "nfs.c" on the Compaq
and the one on this host were *different*.  

The one on lbl-csam was the older one and has a terrible bug, in fact, 
the server won't function properly at all with it.  It has to do with
a section of code that checks for XCOPY's way of passing the wildcards
'*' and '?' over PC-NFS.  The code was missing two braces to surround 
an 'if'.   The required fix is at line 455 and 458 of "nfs.c":

453:      for(i = 0; i < namelen; i++) {
454:            if ((args->da_name)[i] == '*' ||  
455:                (args->da_name)[i] == '?') {   /* add open brace here */
456:                      res->dr_status = NFSERR_NOENT;
457:                      goto end;
458:	        }                                  /* add close brace here */
459:   	  }

Some of you may have ftp'ed this erroneous version.  If you have had
no success with getting SOS to work on your site, this is probably the
cause.  I'm really sorry if this cost you a lot of lost time.

A *good* version is available via anon ftp here now.

----
stan@lbl-csam.arpa		stan@csam.lbl.gov
stan@cory.berkeley.edu