[comp.protocols.tcp-ip.ibmpc] Token Ring Packet driver and "tokreui".

kranenbu@.uucp (Paul Kranenburg) (12/25/89)

A small oversight in the Token Ring Packet driver (from the clarkson archive)
prevented it from working with the "tokreui" program which we still use
at our site.

The problem: the _receiver interrupt procedure fails to reset the direction
bit used in string instructions.

After this patch, everything seems to work as advertised, which means
that we finally we have some connectivity we long sought after.

Here is the diff:

*** ibmtoken.asm.orig   Wed Dec 13 11:42:56 1989
--- ibmtoken.asm        Mon Dec 25 14:14:10 1989
***************
*** 986,991 ****
--- 986,992 ----
                 and     al,not_SA_mask          ; drop SA indicator
                 mov     es:[di],al              ; fix the bit during compare
  
+                cld
                 repe    cmpsb                   ; do string compare now
                 jne     not_mine

nelson@sun.soe.clarkson.edu (Russ Nelson) (12/26/89)

In article <341@rulcs.cs.rul.nl> kranenbu@.uucp (Paul Kranenburg) writes:

   A small oversight in the Token Ring Packet driver (from the
   clarkson archive) prevented it from working with the "tokreui"
   program which we still use at our site.

   The problem: the _receiver interrupt procedure fails to reset the direction
   bit used in string instructions.

Hmmmm...  I'm dubious of the need for this patch.  The 'recv' routine
is called by 'recv_isr', found in head.asm.  Recv_isr save the
registers, switches stacks, clears the direction flag, and calls
'recv'.  After 'recv' returns, the interrupt is acknowledged, the
stack gets restored, 'recv_exiting' gets called, the registers get
restored, and an interrupt return is exited.

Certainly clearing the direction flag at that point won't hurt, but
neither should it help.  If it *does* fix something, then I need to
find out how the direction flag is getting set.
--
--russ (nelson@clutx [.bitnet | .clarkson.edu])  Russ.Nelson@$315.268.6667
Live up to the light thou hast, and more will be granted thee.
A recession now appears more than 2 years away -- John D. Mathon, 4 Oct 1989.
I think killing is value-neutral in and of itself. -- Gary Strand, 8 Nov 1989.
Liberals run this country, by and large. -- Clayton Cramer, 20 Nov 1989.
Shut up and mind your Canadian business, you meddlesome foreigner. -- TK, 23 N.

nelson@sun.soe.clarkson.edu (Russ Nelson) (01/02/90)

In article <NELSON.89Dec25143603@image.clarkson.edu> nelson@sun.soe.clarkson.edu (Russ Nelson) writes:

      A small oversight in the Token Ring Packet driver (from the
      clarkson archive) prevented it from working with the "tokreui"
      program which we still use at our site.

      The problem: the _receiver interrupt procedure fails to reset
      the direction bit used in string instructions.

   Hmmmm...  I'm dubious of the need for this patch.

I'm no longer dubious.  His patch will appear in the next release of
the drivers.  If anyone missed it, I'll mail it out to anyone who
wants it.
--
--russ (nelson@clutx [.bitnet | .clarkson.edu])  Russ.Nelson@$315.268.6667
Live up to the light thou hast, and more will be granted thee.
A recession now appears more than 2 years away -- John D. Mathon, 4 Oct 1989.
I think killing is value-neutral in and of itself. -- Gary Strand, 8 Nov 1989.
Liberals run this country, by and large. -- Clayton Cramer, 20 Nov 1989.
Shut up and mind your Canadian business, you meddlesome foreigner. -- TK, 23 N.