cudcv@warwick.ac.uk (Rob McMahon) (12/20/88)
Just a couple of miscellaneous comments. These are just minor niggles, please
don't take this as criticism, just areas I think could stand some improvement.
One of the first questions asked by Configure is `should the program use
"uuname" rather than trying to read the L.sys file'. This is pretty
disconcerting when you don't run UUCP, and have neither `uuname', nor an
`L.sys' file ...
There is no way to specify an alternate compiler (e.g. gcc) or flags (e.g. -g)
from the top level, CC and CFLAGS are not passed to the lower level Makefiles.
Also it would be nice if the `-I../hdrs' were separated from the `-O' (say
have a COPTS variable which could be -g or -O or `-O -fstrength-reduce' ...).
Using `MAKE=make' and `${MAKE}' in the top-level Makefile instead of just
`make' allows `make -n' to be more helpful on many systems. (The subsidury
makes get run with the -n flag.)
Having the default save filename be `=sender', and having elm come back with
`MAILDIR not defined. Can't expand '='' when you try to accept it is not
encouraging to the first time user. I've had one person who was completely
put off elm by this. MAILDIR should have a sensible default ($HOME ?). Also
if the message is from e.g. `R.J.McMahon', the default will be `=r', couldn't
this be `=r.j.mcmahon' ?
Rob
--
UUCP: ...!mcvax!ukc!warwick!cudcv PHONE: +44 203 523037
JANET: cudcv@uk.ac.warwick ARPA: cudcv@warwick.ac.uk
Rob McMahon, Computing Services, Warwick University, Coventry CV4 7AL, Englandasjl@newcastle.ac.uk (Andy Linton) (12/22/88)
In article <79@titania.warwick.ac.uk> cudcv@warwick.ac.uk (Rob McMahon) writes: >Also if the message is from e.g. `R.J.McMahon', the default will be `=r', >couldn't this be `=r.j.mcmahon' ? This is important - names with '_' should be discarded as they will cause X400 problems later. Names like `R.J.McMahon' will become more prevalent with the advent of X400 to RFC822 (and Grey Book mail in the UK) gateways. Simple patch follows:- *** reply.c.orig Tue Dec 6 09:46:47 1988 --- reply.c Wed Dec 7 17:35:52 1988 *************** *** 418,424 for (i=loc; single_address[i] != '!' && i > -1; i--) if (single_address[i] == '%' || single_address[i] == ':' || - single_address[i] == '.' || /* no domains */ single_address[i] == '@') loc = i-1; if (i < 0 || single_address[i] == '!') i++; --- 418,423 ----- for (i=loc; single_address[i] != '!' && i > -1; i--) if (single_address[i] == '%' || single_address[i] == ':' || single_address[i] == '@') loc = i-1; if (i < 0 || single_address[i] == '!') i++; *************** *** 438,445 loc = strlen(single_address)-1; /* last char */ ! for (i = loc; single_address[i] != '!' && single_address[i] != '.' ! && i > -1; i--) if (trans_to_lowercase) name[index++] = tolower(single_address[i]); else --- 437,443 ----- loc = strlen(single_address)-1; /* last char */ ! for (i = loc; single_address[i] != '!' && i > -1; i--) if (trans_to_lowercase) name[index++] = tolower(single_address[i]); else -- Andy Linton ARPA = Andy.Linton@newcastle.ac.uk "The Postmaster" UUCP = ...!ukc!newcastle.ac.uk!Andy.Linton PHONE = +44 91 222 7784
rob@pbhyf.PacBell.COM (Rob Bernardo) (12/23/88)
In article <79@titania.warwick.ac.uk> cudcv@warwick.ac.uk (Rob McMahon) writes:
+Just a couple of miscellaneous comments. These are just minor niggles, please
+don't take this as criticism, just areas I think could stand some improvement.
As one of the ELM developers I want to thank Rob McMahon for pointing out
so clearly the problems he's found in ELM 2.1PL1. As far as I'm concerned, no
nit is too small to pick.
The good news is that many of the problems Rob pointed out have been
rendered moot in ELM 2.2. Also many others have already been resolved
in ELM 2.2. And for the remaining, a tip of my hat in thanks for
pointing out problems we haven't yet uncovered ourselves.
--
Rob Bernardo, Pacific Bell UNIX/C Reusable Code Library
Email: ...![backbone]!pacbell!pbhyf!rob OR rob@pbhyf.PacBell.COM
Office: (415) 823-2417 Room 4E750A, San Ramon Valley Administrative Center
Residence: (415) 827-4301 R Bar JB, Concord, California