scs@vax3.iti.org (Steve Simmons) (04/14/89)
Haven't turned 2.2 over to our users yet, but so far it's working good for me. Found one problem during the compilation -- if you're on 4.3 bsd and using dbm you get a 'unreachable statement' during compilation of aliasdb.c. The patch at the end of this posting fixes that. When building using GNU make, it apparently treats $(MAKEFLAGS) somewhat differently than does the 'canonical' make. In particular, I had to change some makefile constructs from cd src; $(MAKE) -$(MAKEFLAGS) $@ to cd src; $(MAKE) $(MAKEFLAGS) $@ Using BSD make, these statements resolve to cd src; make - all to cd src; make all respectively; both of them correctly build elm. Using GNU make, they resolve to cd src; make --j1 -S all and cd src; make -j1 -S all respectively; the former gives an error message from make while the latter works fine. I'll try it at home this weekend on a vanilla SysV make and report. Finally, there is some bizarre performance using aliases created under 2.1 with 2.2. The alias command to list aliases gives you a list of aliases by apparently cating the .aliases-text file. But try to use the aliases and you get junk. Run the listalias external command and you get junk. Run newaliases and everything works fine after that. I don't really have a major problem with having to rebuild my aliases yet again, but lets make elm fork 'listalias' rather than just catting the file. The resultant output is prettier, more consistant, and would not give the false impression that the aliases database is OK. The patch for aliasdb.c follows. RCS file: RCS/aliasdb.c,v retrieving revision 1.1 diff -c -r1.1 aliasdb.c *** /tmp/,RCSt1009823 Fri Apr 14 11:41:17 1989 --- aliasdb.c Fri Apr 14 11:31:21 1989 *************** *** 203,209 strcat(expanded, " "); /* add a single space... */ strcat(expanded, comment); /* ...and add comment */ return(0); ! #endif #ifndef LOOK_CLOSE_AFTER_SEARCH --- 203,209 ----- strcat(expanded, " "); /* add a single space... */ strcat(expanded, comment); /* ...and add comment */ return(0); ! #else #ifndef LOOK_CLOSE_AFTER_SEARCH *************** *** 242,247 strcat(expanded, comment); /* add comment */ return(0); } #endif } --- 242,248 ----- strcat(expanded, comment); /* add comment */ return(0); } + #endif #endif } Steve Simmons Just another midwestern boy scs@vax3.iti.org -- or -- ...!sharkey!itivax!scs "Hey...you *can* get here from here!"