[comp.sys.apollo] Typos in /sys/ins/*.ins.c and RE: gpr_$blt

GBOPOLY1@NUSVM.BITNET (fclim) (03/08/89)

     (1) I like to thank all who send in pointers to my queries on
         GPR BLTs.  Your replies have been very helpful.

     (2) I have discovered a few typos in /sys/ins/gpr.ins.c and
         /sys/ins/mts.ins.c.  I am using SR9.7.
         In /sys/ins/gpr.ins.c, gpr_$inq_background() and
         gpr_$inq_foreground() should be declared to return
         gpr_$pixel_value_t instead of being procedures.

         They are some typos in the comments.  It seems that
         someone had used a global substitution mechanism to
         replace "int" with "short".  So "intensity" becomes
         "shortensity".

         In /sys/ins/mts.ins.c, mts_$first_a and mts_$last_a have
         been #define-d as

#define mts_$first_a mts_$unit_a;   /* comments */
#define mts_$last_a mts_$buffer_offset_a;   /* comments */

        For those who can't find the bugs, note that the semicolon
        is like the proverbial mouse who entered an elephant's ear.

        I wander how many more typos I'll find.

    (3) Where can I send a program to be included on the Adus tapes?
        I prefer an email address.  Thanks.

fclim.  :-)

fclim          --- gbopoly1 % nusvm.bitnet @ cunyvm.cuny.edu
computer centre
singapore polytechnic
dover road
singapore 0513.

oj@apollo.COM (Ellis Oliver Jones) (03/10/89)

In article <8903080326.AA13489@umix.cc.umich.edu> GBOPOLY1@NUSVM.BITNET (fclim) writes:
>
>     (2) I have discovered a few typos in /sys/ins/gpr.ins.c ...
>         I am using SR9.7.
>         In /sys/ins/gpr.ins.c, gpr_$inq_background() and
>         gpr_$inq_foreground() should be declared to return
>         gpr_$pixel_value_t instead of being procedures.

Quite right.  Thanks for the bug report.  This was fixed by sr10.
If this bug affects you (i.e. you're still on SR9.7 or less
and you need these functions, just replace the declarations 
for these functions with

std_$call gpr_$pixel_value_t gpr_$inq_background();
std_$call gpr_$pixel_value_t gpr_$inq_foreground();

in /sys/ins/gpr.ins.c

The mts bugs appear fixed too (but that's not my area).

/oj