[net.bugs.uucp] Bug in uuxqt.c

bobvan (06/12/82)

Recently, I've noticed X.files lying around /usr/spool/uucp with no
daemon running to execute them.  A quick check of LOGFILE showed that a
given invocation of uuxqt never executed more than 16 X.files.  I've
traced the bug to a missing call to fclose() in uuxqt.c.  A maximum of
20 open files less 3 for stdin, stdout, stderr, and one to read the
spool directory leaves 16.

We've only been running uucp for about a month, and I find it to believe
that no one else noticed this bug.  Is there a collected log of uucp
bugs hidden on some system somewhere?

We are running 4.1bsd.  Diff -c follows:

	*** uuxqt.c	Fri Jun 11 16:06:45 1982
	--- uuxqt.orig.c	Fri May  7 10:59:42 1982
	***************
	*** 202,208
				sscanf(&buf[1], "%s", file);
				unlink(file);
			}
	- 		fclose(xfp);
			unlink(xfile);
		}
	  

	--- 202,207 -----
				sscanf(&buf[1], "%s", file);
				unlink(file);
			}
			unlink(xfile);
		}

Bob Van Valzah
(...!decvax!ittvax!tpdcvax!bobvan)