[net.bugs.uucp] Bug in cntrl.c

kg (08/08/82)

Uucp's have never worked for us.  They've always caused a Segmentation
Fault while uucico was running.  Adb was no help, it just listed a
million sigtramps and aborts.  I Finally tracked down the problem.  The
work file contained only 5 fields.  But uucico expected a file of 6
fields.  I don't know if this is an error in the program that writes
the file or reads the file, but for robustness, I fixed the reader.
(As you can see below, it checks for "at least 5 items" and then goes
merrily along and uses 6).

Here's the fix.  The added lines marked with <<<<'s.
Around line 150 or so in cntrl.c...

    ASSERT(i > 4, "ARG COUNT - %d\n", i);
    if (i < 6)				<<<<<<<<
	W_MODE = "0666";		<<<<<<<<
    sprintf(msg, " %s %s %s %s %s %s",
	    W_FILE1, W_FILE2, W_USER,
	    W_OPTNS, W_DFILE, W_MODE);

						Ken Greer
						HP Labs