[net.bugs.uucp] 4.3BSD uucp bugs?

shannon@sun.uucp (Bill Shannon) (10/31/86)

Recently two sites that we talk to upgraded to the 4.3BSD uucp
(one running on 4.3, the other running it on some other system).
Immediately after they upgraded, we began having problems talking
to them.  Our conversations would usually end in the middle with
"expected 'S', got FAIL" or something similar.  One of the sites
has since converted back to the 4.2 uucp and the problems have
disappeared.  Has anyone else had similar problems?  Does anyone
know of any bugs in the 4.3 uucp?

					Bill Shannon

P.S.  We're running the standard uucp that comes with SunOS 3.0.
It hasn't changed in years, and predates the 4.2BSD uucp, but is
newer than V7.

spaf@gatech.EDU (Gene Spafford) (11/01/86)

In article <8766@sun.uucp> shannon@sun.uucp (Bill Shannon) writes:
>Recently two sites that we talk to upgraded to the 4.3BSD uucp
>(one running on 4.3, the other running it on some other system).
>Immediately after they upgraded, we began having problems talking
>to them.  Our conversations would usually end in the middle with
>"expected 'S', got FAIL" or something similar.  One of the sites
>has since converted back to the 4.2 uucp and the problems have
>disappeared.  Has anyone else had similar problems?  Does anyone
>know of any bugs in the 4.3 uucp?


Yes indeedy.  The following change to pk1.c should fix the problem your
neighbors are having.  Symptoms are that the bug manifests itself when
noise causes a packet to get mangled and you get an EXPECT/FAIL error.
Somebody broke the code between the Beta release version and the final
4.3 release.

*** pk1.c.orig	Thu Sep 18 22:12:54 1986
--- pk1.c	Wed Oct  1 22:25:13 1986
***************
*** 196,202 ****
  		return;
  	}
  	if (k && pksizes[k] == pk->p_rsize) {
! 		pk->p_rpr = (h->cntl >> 3) & MOD8;
  		pksack(pk);
  		bp = pk->p_ipool;
  		if (bp == NULL) {
--- 196,202 ----
  		return;
  	}
  	if (k && pksizes[k] == pk->p_rsize) {
! 		pk->p_rpr = h->cntl & MOD8;   /* This is the correct one. EHS */
  		pksack(pk);
  		bp = pk->p_ipool;
  		if (bp == NULL) {
-- 
Gene Spafford
Software Engineering Research Center (SERC), Georgia Tech, Atlanta GA 30332
CSNet:	Spaf @ GATech		ARPA:	Spaf@ics.GATECH.EDU
uucp:	...!{akgua,decvax,hplabs,ihnp4,linus,seismo,ulysses}!gatech!spaf

grr@cbmvax.commodore.COM (George Robbins) (11/03/86)

In article <5493@gatech.EDU> spaf@gatech.UUCP (Gene Spafford) writes:
>In article <8766@sun.uucp> shannon@sun.uucp (Bill Shannon) writes:
>>Recently two sites that we talk to upgraded to the 4.3BSD uucp
>>(one running on 4.3, the other running it on some other system).
>>Immediately after they upgraded, we began having problems talking
>>to them.  Our conversations would usually end in the middle with
>>"expected 'S', got FAIL" or something similar.  One of the sites
>>has since converted back to the 4.2 uucp and the problems have
>>disappeared.  Has anyone else had similar problems?  Does anyone
>>know of any bugs in the 4.3 uucp?
>
>Yes indeedy.  The following change to pk1.c should fix the problem your
>neighbors are having.  Symptoms are that the bug manifests itself when
>noise causes a packet to get mangled and you get an EXPECT/FAIL error.
>Somebody broke the code between the Beta release version and the final
>4.3 release.

Does anybody know if this also crept into Ultrix 1.2?  I've been getting
a lot of these EXPECT/FAIL errors lately...
-- 
George Robbins - now working for,	uucp: {ihnp4|seismo|caip}!cbmvax!grr
but no way officially representing	arpa: cbmvax!grr@seismo.css.GOV
Commodore, Engineering Department	fone: 215-431-9255 (only by moonlite)