[comp.windows.x] Patch #2 for X11R3

peterson@SW.MCC.COM (James Peterson) (11/30/88)

The comments at the head of patch #2 indicate
that the fixes to server/os/4.2bsd/osinit.c are because of
"rgb.dir corruption".  Looking at the patch, however, seems
to show it to affect the version number (1.19 to 1.21) and
code that seems to deal with where to put debug and error log
messages (ADMPATH file opening).

keith@EXPO.LCS.MIT.EDU (Keith Packard) (11/30/88)

> The comments at the head of patch #2 indicate
> that the fixes to server/os/4.2bsd/osinit.c are because of
> "rgb.dir corruption".  Looking at the patch, however, seems
> to show it to affect the version number (1.19 to 1.21) and
> code that seems to deal with where to put debug and error log
> messages (ADMPATH file opening).

This is correct.  The rgb.dir file was being corrupted by output
written to stderr.  dbm(3) opens the database files read/write, even
when read-only access would suffice.  If the error file open failed, it
left file descriptor 2 unused, the next file opened happened to be
rgb.dir; it got file descriptor 2 and all error output went to it.

So, the "fix" was to make sure something viable was connected to file
descriptor 2.
						Keith Packard
						MIT X Consortium
						(617) 253-1428
						keith@EXPO.LCS.MIT.EDU