[comp.windows.x] Patch 6 for xtroff

moraes@AI.TORONTO.EDU (Mark Moraes) (07/07/89)

Patch 6 fixes xtroff to work with the Berkeley ditroff distribution,
as well as a couple of minor annoyances with scrollbars, the Minibuf
widget and the Imakefile.  I also added a note about the use of
v?printf() functions - I was reminded that some systems still don't
have those functions in their libc. The patch priority is High for
those who use Berkeley ditroff, Low for everyone else.

I've put the latest version of xtroff up for anonymous ftp on
ai.toronto.edu (128.100.1.65) in pub/X/xtroff.tar.Z and
expo.lcs.mit.edu (18.30.0.212) in contrib/xtroff.tar.Z. This version
is at patchlevel 6. (For those not on the Internet, the comp.source.x
version will be at patchlevel 6)

For those who ftp'ed the version at patchlevel 6, there's also a
patch file xtroff.fix6, which you can just feed to patch -p.

The checksum for xtroff.tar.Z is 
	48224   336

On ai.toronto.edu:

-rw-r--r--  1 moraes      14040 Jul  6 18:26 pub/X/xtroff.fix6
-rw-r--r--  1 moraes     343627 Jul  6 18:26 pub/X/xtroff.tar.Z

On expo.lcs.mit.edu: 

-rw-rw-rw-  1 ftp      30          14040 Jul  6 18:39 contrib/xtroff.fix6
-rw-rw-rw-  1 ftp      30         343627 Jul  6 18:33 contrib/xtroff.tar.Z

CHANGES.Patch6
::::::::::::::
This is a set of fixes from Adam de Boor <bsw!adam@uunet.UU.NET>. I haven't
tested the code for the Berkeley ditroff distribution, because I don't have
Berkeley ditroff. People with Berkeley ditroff will need this patch
and should define -DBEZERKELYISM in the Imakefile.

It also fixes a small problem Adam reported with the Minibuf.

I've updated the distributions on ai.toronto.edu and expo.lcs.mit.edu to
add this patch - the patch itself is in xtroff.fix6.

---------------------------------------------------------------------------
Date: Sun, 2 Jul 89 21:12:46 PDT
From: bsw!adam@uunet.UU.NET (Adam de Boor)
To: moraes@csri.toronto.edu
Subject: fixes to xtroff level 5

There are a few bugs in the handling of berkeley-style ditroff (which I use
here). The patches are enclosed below. There was also a problem with the
next-section and prev-section actions not calling SetScrollBar, leaving the
thumb in the wrong place.

A note on the #ifndef BEZERKELYISM for the 'w' command code -- I ran into a
problem with a table of contents in one of my documents, where ditroff
produced something like

w54.20.20.20.20.20.20.

and so on after the text for the TOC entry in order to draw the dotted line
leading up to the page number. PutCharacterString was passing the character
20 to PutCharacter, causing error messages and, eventually, a segmentation
fault. None of the drivers in the Berkeley ditroff distribution handles
the text after a w as if the w were a c, as your code does, but that
doesn't mean the ATT stuff doesn't do so, hence the #ifndef.

You might also want to add a comment to the Imakefile about -DBEZERKELYISM,
since all the things (except Dz [bezier spline]) now work and if you
don't define the constant, you'll get error messages when you run xtroff
on a berkeley-ditroff output file.