[comp.windows.x] Function prototypes in .h files

simkin@ginosko.samsung.com (Rick Simkin) (09/06/89)

I'm working with a C compiler which requires function prototypes, and have just
spent a day converting released X header files to include this information.

Sample original code:

    extern void XtStringConversionWarning();
        /* String   from;       */  /* String attempted to convert.     */
        /* String   toType;     */  /* Type attempted to convert it to. */


Converted into function prototypes:

    extern void XtStringConversionWarning(
    #ifdef NEED_PROTOTYPE
        String   from,        /* String attempted to convert.     */
        String   toType       /* Type attempted to convert it to. */
    #endif
    );

The converted code will still work with a compiler that doesn't understand
function prototypes, but defining NEED_PROTOTYPE will satisfy the compiler
that requires them.


Oh please, X people, could the X header files be modified along these lines in
the next release, to save lots of reconversions in the future?
-------------------------------------------------------------------------------
Rick Simkin                    || Phone: +1 (508) 685-7200 x134 (fax 685-4940)
Samsung Software America, Inc. || Internet: simkin@samsung.com
1 Corporate Drive              || UUCP: {uunet,ulowell}!ginosko!simkin
Andover, Mass.  01810  USA     ||       decvax!bu-tyng!ulowell!ginosko!simkin
-------------Any opinions expressed are my own, not my employer's.-------------

rws@EXPO.LCS.MIT.EDU (Bob Scheifler) (09/07/89)

    Oh please, X people, could the X header files be modified along these lines
    in the next release, to save lots of reconversions in the future?

Why don't you send your changes to xbugs@expo.lcs.mit.edu, so the "X people"
don't have to duplicate your work?