[comp.windows.x] DiskSourceDestroy

kai@uicsrd.csrd.uiuc.edu (10/14/89)

I found and fixed a bug in the DiskSourceDestroy() routine (we have x11r3,
patch level 10).  The file wasn't closed before resources were deallocated.
It's a simple one line addition to lib/Xaw/DiskSrc.c.

This problem killed a client of mine when it ran out of file descriptors.

Patrick Wolfe    (pat@kai.com, uunet!kailand!pat)
System Manager,  Kuck and Associates, Inc.
"I'm the NRA"


===================================================================
RCS file: DiskSrc.c,v
retrieving revision 1.1
diff -c -r1.1 DiskSrc.c
*** /tmp/,RCSt1015463	Fri Oct 13 14:39:38 1989
--- DiskSrc.c	Fri Oct 13 13:20:16 1989
***************
*** 421,426 ****
--- 421,427 ----
  {
      DiskSourcePtr data;
      data = (DiskSourcePtr) src->data;
+     fclose (data->file);
      XtFree((char *) data->buffer);
      if (data->is_tempfile) {
          unlink(data->fileName);
===================================================================

kit@EXPO.LCS.MIT.EDU (Chris D. Peterson) (10/16/89)

> I found and fixed a bug in the DiskSourceDestroy() routine (we have x11r3,
> patch level 10).  The file wasn't closed before resources were deallocated.
> It's a simple one line addition to lib/Xaw/DiskSrc.c.

This has already been reported and fixed, a fixed version will be in X11R4 when
that release is distributed.


						Chris D. Peterson     
						MIT X Consortium 

Net:	 kit@expo.lcs.mit.edu
Phone:   (617) 253 - 9608	
Address: MIT - Room NE43-213