[comp.windows.x] Fix to bug in Xpostit

geof@aurora.com (Geoffrey H. Cooper) (02/21/90)

Xpostit was dying for me when I create a note.  Found a "dangerous
macro" bug:

In note.c, MakeNoteWidget:

 >       if (app_res.scroll_bar)
 >         {
 >               SetArg(XtNscrollVertical, XawtextScrollAlways);
 >               }
 >         else
 >               SetArg(XtNscrollVertical, XawtextScrollWhenNeeded);

However, in xpostit.h:

   #define SetArg(which, val)	XtSetArg(args[nargs], (which),\
					(XtArgVal) (val)); nargs++
							   ^^^^^^^

This is clearly a buggy macro.  You can fix it by putting the entire
macro in parentheses and changing the ; to a ,.  Alternately, fix the
immediate problem by putting braces around the ELSE clause.

- Geof
-- 
geof@aurora.com / aurora!geof@decwrl.dec.com / geof%aurora.com@decwrl.dec.com