[comp.windows.x] Is XtDiskSourceDestroy

ted@mbunix.mitre.org (Ede) (05/08/90)

I'd like to use R4, but right now I'm trying to write something to
port to our IBM box that runs MVS and R3.  

I tracked the bug (running out of streams) down to a missing fclose in
DiskSrc.c.


void XtDiskSourceDestroy (src)
  XtTextSource src;
{
    DiskSourcePtr data;
    data = (DiskSourcePtr) src->data;
    /* I added the following line. */
    fclose(data->file);  
    XtFree((char *) data->buffer);
    if (data->is_tempfile) {
        unlink(data->fileName);
	XtFree((char *) data->fileName);
    }
    XtFree((char *) src->data);
    XtFree((char *) src);
}

Has this bug been fixed by an official/unofficial patch?  Would there be any
problems adding putting this code back into our production library?

|Ted Ede -- ted@mbunix.mitre.org -- The MITRE Corporation -- Burlington Road|
| linus!mbunix!ted -- Bedford MA, 01730 -- Mail Stop B090 -- (617) 271-7465 |
|                   - this line intentionally left blank -                  |
+---------------------------------------------------------------------------+

kit@EXPO.LCS.MIT.EDU (Chris D. Peterson) (05/09/90)

> I tracked the bug (running out of streams) down to a missing fclose in
> DiskSrc.c.

Yes this is a real bug in the R3 version of the Athena widgets.  I don't believe
that this made it out as an R3 public fix.  The problem has been corrected in
R4, however.

> Would there be any
> problems adding putting this code back into our production library?

Not that I know of.


						Chris