jta@bilbo.la.locus.COM (Jim Anderson) (08/24/90)
A couple of nits related to structures in the sample server code... Many structures have tags beginning with an underscore. Since names beginning with underscore are reserved for the compiler, this isn't exactly legal. I would suggest using the same name for the structure tag and the typedef name. If there are compilers that can't handle this, then the leading underscore may be less offensive that other alternatives. (Microsoft uses the prefix "tag" in MS Windows. Yuck!) Many structures don't have tags at all. This makes life difficult when generating function prototypes, as you cannot express pointers to these structures as incomplete types. Please put tags on all structures that are used as function parameters. Most of the offending structures are in xproto.h.