moss@brl.mil (Gary S. Moss (VLD/VMB) <moss>) (09/19/90)
Cause: In xrn/compose.c: followup(), the declaration for timeString is wrong,
an obvious typo:
char *timeString[24]; /* wrong */
char timeString[24]; /* right */
This buffer is used to hold the date string returned from asctime(). The
result was that the string was being copied to a pointer array.
Symptom:
On a Sun 3/80 running SunOS 4.0.3, this resulted in a newline after
the year, causing the orphaned " GMT" portion of the date line to confuse
the xrn/server.c:postArticle function into prematurely terminate the header
that it sent to the NNTP server. The end result of this was that when
doing a "followup" to an article, inews barfs with a "No title" error.
Below is an unofficial patch.
-Gary
*** compose.c.old Tue Sep 18 13:27:38 1990
--- compose.c Tue Sep 18 13:16:52 1990
***************
*** 1643,1649 ****
#ifdef GENERATE_EXTRA_FIELDS
long clock;
! char *timeString[30];
#endif
if ((newsgroup->status & NG_UNPOSTABLE) == NG_UNPOSTABLE) {
--- 1643,1649 ----
#ifdef GENERATE_EXTRA_FIELDS
long clock;
! char timeString[30];
#endif
if ((newsgroup->status & NG_UNPOSTABLE) == NG_UNPOSTABLE) {haozhou@acsu.buffalo.edu (hao zhou) (09/19/90)
In article <1990Sep18.134131@brl.mil> moss@brl.mil writes: >Cause: In xrn/compose.c: followup(), the declaration for timeString is wrong, > an obvious typo: > > char *timeString[24]; /* wrong */ > char timeString[24]; /* right */ > I believe this problem was cured in xrn6.12.1. Try the new version. -- Hao Zhou -- Internet:haozhou@acsu.buffalo.edu BITNET:haozhou%acsu.buffalo.edu@UBVM.BITNET UUCP: uunet!acsu.buffalo.edu!haozhou