[comp.windows.x] tvtwm patch 3: icon weirdness

moss@brl.mil (Gary S. Moss (VLD/VMB) <moss>) (10/03/90)

Hi,
	First, let me say that tvtwm is really great!  I just noticed a
small glitch in the latest version from expo which includes patch 3, and
am seeing some of my icons get stretched vertically.  So far this behavior
has been limited to iconified xterms, and only effects about half of them.
They increase in height about 50% with the extra height below the label:

	+-----------+
	| @@@@@@@@@ |
	| @@@@@@@@@ |
	| @@@@@@@@@ |
	| @@@@@@@@@ |
	| @@@@@@@@@ |
	|  console  |
	|           |
	|           |
	|           |
	+-----------+

	This doesn't always occur the first time the window is iconified,
but once it occurs, it seems to be permanent.  I am *not* using the NoIconTitle
or IconTitle commands.  I do use xterm escape sequences to set the icon title
to the host name.

	I am running X11R4 patches 1-14 under Sun OS 4.0.3.  Anyone else
seen this behavior?  Tom, are you there?

-Gary
PS: Anyone loaded an image the size of their virtual root onto their root
window and the same image scaled down onto the panner?  

VirtualDesktopBackgroundPixmap	"biggodamthing"
PannerBackgroundPixmap		"panner"

It takes almost a minute to load the big image, but it's worth it!

moss@brl.mil (Gary S. Moss (VLD/VMB) <moss>) (10/03/90)

In article <13999@smoke.BRL.MIL>, moss@brl.mil (Gary S. Moss (VLD/VMB) <moss>),
that's me, writes:
|> I just noticed a
|> small glitch in the latest version from expo which includes patch 3, and
|> am seeing some of my icons get stretched vertically.  So far this behavior
|> has been limited to iconified xterms, and only effects about half of them.
|> I do use xterm escape sequences to set the icon title to the host name.
It just happened on an xrn window, so the reference to xterm is probably
irrelevant.

stolcke@ICSI.Berkeley.EDU (Andreas Stolcke) (10/03/90)

In article <13999@smoke.BRL.MIL>, moss@brl.mil (Gary S. Moss (VLD/VMB) <moss>) writes:
|> 
|> Hi,
|> 	First, let me say that tvtwm is really great!  I just noticed a
|> small glitch in the latest version from expo which includes patch 3, and
|> am seeing some of my icons get stretched vertically.  So far this behavior
|> has been limited to iconified xterms, and only effects about half of them.
|> They increase in height about 50% with the extra height below the label:
|> 

I was about to post the patch below when I read your message...
The icon size is recomputed incorrectly when the window managers learns of
an icon title change.  This small fix works for me, pending an official
one from Mr. TWM himself:

*** ./events.c.dist	Mon Oct  1 18:53:27 1990
--- ./events.c	Tue Oct  2 12:04:48 1990
***************
*** 923,929 ****
  
      Tmp_win->icon_w_height = Tmp_win->icon_height;
      if (Tmp_win->icon_title)
! 	Tmp_win->icon_w_height += Tmp_win->icon_height;
      Tmp_win->icon_y = Tmp_win->icon_height + Scr->IconFont.height;
  
      XResizeWindow(dpy, Tmp_win->icon_w, Tmp_win->icon_w_width,
--- 923,929 ----
  
      Tmp_win->icon_w_height = Tmp_win->icon_height;
      if (Tmp_win->icon_title)
! 	Tmp_win->icon_w_height += Scr->IconFont.height + 4;
      Tmp_win->icon_y = Tmp_win->icon_height + Scr->IconFont.height;
  
      XResizeWindow(dpy, Tmp_win->icon_w, Tmp_win->icon_w_width,

-- 
Andreas Stolcke
International Computer Science Institute	stolcke@icsi.Berkeley.EDU
1957 Center St., Suite 600, Berkeley, CA 94704	(415) 642-4274 ext. 126