nfs@notecnirp.Princeton.EDU (Norbert Schlenker) (01/03/90)
Here are some preliminary bug reports on the posted headers for v1.5.0. I regret that no cdiffs are included, but my headers differ significantly from Andy's. (And I won't change mine for these inferior ones :-) <signal.h> sig_atomic_t must be defined even if _POSIX_SOURCE isn't defined (ANSI 4.7) <time.h> needs size_t (ANSI 4.12) <unistd.h> _SC_CLOCKS_PER_SEC should be _SC_CLK_TCK (POSIX Table 4-2) _PROTOTYPE(int setuid, (uid_t __uid)); /* not int __uid */ (POSIX 4.2.2) <sys/utsname.h> The structure allocates storage; it should be just a definition (POSIX 4.4.1) <sys/wait.h> WIFSIGNALED() macro uses x instead of s WSTOPSIG() has redundant & (i.e. (_HIGH(s) & 0377) == _HIGH(s), always) Style preference: Use all hex or all octal - this header is an abomination! Perhaps someone can change the headers and post cdiffs. Final note: Does anyone know the reason for the "TEMPORARY HACK"s in <sys/stat.h>? Norbert