cs00chs@unccvax.uncc.edu (charles spell) (08/31/90)
Sould we add the recent fix (posted by ast) of fs/open.c to the official
PC Minix 1.5.10 distribution?
--
.--------------------------. ... |On the border of your mind lies a place
|uunet!mcnc!unccvax!cs00chs| (") |where dreams and reality are one...I will
`--------------------------'-w-U-w-|take you there, for I am the subject...
\%\%\%\%\%\%\%\%\%\%\%\%\%\%\%\%\%\|the subject of your imagination. -Aldo Novaast@cs.vu.nl (Andy Tanenbaum) (08/31/90)
In article <2651@unccvax.uncc.edu> cs00chs@unccvax.uncc.edu (charles spell) writes: > >Sould we add the recent fix (posted by ast) of fs/open.c to the official >PC Minix 1.5.10 distribution? The proper crc is 08922 13329 open.c If the fix gives this, apply it. (I'm not sure which fix you mean. There are so many of them, sigh). Andy Tanenbaum (ast@cs.vu.nl)
droege@infko.UUCP (Detlev Droege) (09/10/90)
In article <7406@star.cs.vu.nl> ast@cs.vu.nl (Andy Tanenbaum) writes: >In article <2651@unccvax.uncc.edu> cs00chs@unccvax.uncc.edu (charles spell) wr ites: >>Sould we add the recent fix (posted by ast) of fs/open.c to the official >>PC Minix 1.5.10 distribution? >The proper crc is >08922 13329 open.c Well, ahem, this is the CRC for original 1.5.10 fs/open.c, but then there was a patch concerning a misplaced parenthesis which caused Andy to wonder how MINIX could ever work. It's line 58 of fs/open.c where the original 1.5.10 source says: put_inode(new_node(user_path, bits, (zone_nr) addr), (off_t)size*BLOCK_SIZE); | with this -----------------------------------------+ wrongly placed parenthesis. It should be with the parenthesis at the end, as new_node has four parameters and put_inode has just a single one: put_inode(new_node(user_path, bits, (zone_nr) addr, (off_t)size*BLOCK_SIZE)); The CRCs are: 08922 13329 open.c.orig # orig 1.5.10 with misplaced parenthesis 36211 13329 open.c # corrected 1.5.10 Bye Detlev Detlev Droege droege@infko.UUCP Uni Koblenz, (..!unido!infko!droege) Inst. f. Informatik Voice: +49 261 9119-421 Rheinau 3-4, D-5400 Koblenz, Germany Fax: +49 261 37524 -- Detlev Droege droege@infko.UUCP Uni Koblenz, (..!unido!infko!droege) Inst. f. Informatik Voice: +49 261 9119-421 Rheinau 3-4, D-5400 Koblenz, Germany Fax: +49 261 37524