[comp.os.minix] Problems with WMAIL 3.63 on 68000-Minixes

archer%segin4.segin.fr@relay.prime.com (Vincent Archer) (11/12/90)

Well, I've found wmail to be wonderful... But not on my atari ST! :-)

There are two bugs and one "mistake" in it. The two bugs are horrendous:
Two NULL pointers are referenced, once for reading, once for WRITING!!!
The mistake is the usual int-to-pointer cast when you don't declare that
malloc() returns pointers (i.e. you forget #include <stdlib.h>...)


Below is a cdiff files for the three modules in fault (compressed-uuencoded,
as usual). While I was at it, I also corrected the fact that one can
add endlessly "Re: " when replying to a reply that replied to a reply that
replied... And a test reordering for optimisation (I saw it, so I rewrote
it. Its compulsive...).

BEWARE: This is not an official patch! Keep your 3.63 source handy for the
time of Fred's next official patch (No Fred, I don't spend ALL my time
studying your programs ;-> )

table
 !"#$%&'()*+,-./0123456789:;<=>?
@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_
begin 644 wmail.cdif.Z
M'YV-*@*"<.'BQ9TV8=*P<3'#Q@R#"-FD"3/'Q9@$4\+0 >'DC1T0,6" Q*&#z
MA@T=,F: S)$#AH(6,$$<#".1HD6,==QP] @R!@@9,G3 N"'TQLJ6"@(J7<I4y
M15*!(5G$J %BZ<N846/8  $3I@(0($:D<3.&31TR94#PF)-GS@LZ>>"4J8C&x
MQ]>P8\N>3<L#SATR+NK>%4O6+%JU<^C(&7LFL-T5> OO14R'C$0QC@?G-<PWw
M,9DT;S*#):SWL(B9"@.+N/M4Q<""J!<V?'AP3!O %S-N[/@QY,B2)V7XC,'2v
M95>9;6SCQJAQ9V^1,F#H:*BC!E7B2)MJ#]@:Q(P9+&;DJ*KT+M@[:-YLB=$%u
M1 \0*,:@"2.G:@HG59@PV6$>1&(Y8\"1!PIAD$&&'%^,,08+((@@0@K\@076t
M?P$.6."!7XBA((,.0JA "!+. <=B;M!A!@ISU"&&&F6,00>'4I2A P@ES"$"s
M@VR404<+/J2X8HMT> A6?R..92(*(G#AAA%RO-'&C#72V((,-+A Y1Q*WNA?r
M&6Z@)0>#>-"11AMEH)""D!(66>*)(E#Q!I18NJ$E>NK!T(6'QWW' @T^==5"q
M?W2NU]Y[\<U7GPKWY;=??Q0*2*"!"&[8X(,1AJA8A8]BJ.&"DWH((EAIF '?p
M?V2U 0<*.>[8HXHLN@BCC TR2,.9'X*0@(@D'NECJR\V&".<6J;*XZY >BIAo
M&6S,D5:C Q+K*@C"KOJCBV@2F2N;2C+I))Q24FDE#7%JJ6R797P)0IACEGEFn
MI6"I>62;;](8+H.!VNGA=MIU%\-44LE@E%42RH2&0FFAH((8<(!@@@E5(0Q"m
M".^=H.0)*8" \ HKL-MPPA%S <,)E=8*JJ@H /B%&6^PX>7#A,I'GWWXZ5?Ql
M'K4F$"I\*LP1AAUEF$&P>Q&_< ((?/!1E<X\^YPCT""<X +%_EWJJ!ENA$$Fk
M@TCW3+"Q"8"%K++^N7LBU5:7P6&-+Z!=HY;I70V"R2BK7"[6.VN=H[%@]0'"j
MUVG1#*+-).=<M])I]1#TT$4?/?C/AC?]=,7,HD"VVUD3SK77R2XKMN15NRV"i
MVC8RV+;9_BU^-W^?@M ':P&_X-H0:+2X!@@WWY$60GG(M!@=:='Q!@ATS+<1h
MX2Y4]4)_-Q/(!AMOV$X&YV4S"(,,%3=N1!!,3%'$S%>UT-,-_6[E)Z #+VVPg
MPPMOS'+3$U=\<<;]'<PQ^Q^'G'KR@B?-^.%$&YV_W86+V..B!J"I=8YTE=L:f
MZHZ5.=J1#&XI6QG$X..R0R5*9C7#E9'&=L"SN05T;',2Z2 H-W,E\'0BPQS8e
M-+@FZ'D.A*(3(=WTA\(AM>YUL1O#[&IWNS#D[@Z[Z]WO@M<<XAD/>22C"?.<d
MYT+23:]Z[[E>]K8' IKAJRGZRH$-6! =&9"'.S:T%'WHX(;?$<H-90A3JK@"c
MDHJ]X"<B<4UT0 "9&&@,9?5!E8[< P*?R2$QJ=H!M'0TK#+$H8QJB=H8RRC(b
M-;XG6F@,4\46>)[R%2Q:RCKD[WB@2#F0\7>0F6/Z,&E(1(Z2D#TJY2;?XX8Za
MM"%5W -+ C;WN3&4P)8RL!(9I!2#&[B@EW, 2PE:$(-<%C.8):@2#<B0MA;Xz
M\@8J*P%#8#"ONR0@ 2B()!T<^4A49K*,%?M!TWQP@AD-[00LL"8V,4D'C=0Ay
MF(TC0A&84 0J%($(X6R:"LK9M*:E\SC$J0$7I\>5KK!.C)Y$Y!G3N,T]>B\&x
M;H1C521:QSN^(8^.[&,:_MA0.C32FZI,9&(6^8:/;J2;JM+F)%.(GI_I<2,3w
M=$(2F/ %>E)!80PCI29%VLZ$@E*B"ZO9(%7US=^=DJ@AY0$K70G+*EJ3EK>,v
M:BYEL,MA]O*7-P@F+XTI V0JDYG#?&8TIUE-66)3F]P<:B$UF<\3D-.<_E3Gu
M2X?53CJ\DVGRM.D]V[I/N**S.P2!2$)DXQ"((&0L-]&-<T BDAB0Q"0Z<.Q1t
MC!.3@QS6#8G-R6+W]9,8".4D,+A.<5IS1>XH!00UF(% :T #+P+,5JN3)=] s
M4,8O2 2-<\"8QE:7.C90I*,\JNUMY\)'X8YE+I2$UF\A^88$&0J>(!A#'>0@r
M!RYMQ'LH>(,9S/"%(!$P1VY E1CJL-V*><^W@$0E\\:@$="X(60W!,$5TE+&q
M.X!@#?456+EZ%SL0D&D..CL#<>DSPC(4R+]S"7!:8E>@<E7DB '+J!_3Z]'Np
MH5:U+& M#0KJ%5G&UE:S-2YN==L?WDHH>>CM*/?^EF+FVO:XT!4Q<FO68E36o
MMH+0E2YUK<O&[&ZWNY!3#'C%2UXSF%>Y%.;1>MO[AO>F\,/]<9U\Z=N\^^87n
D/?L%7G__J^!@$IA!U3TPE\,@8! PV$L/5L'Q(KS']TRXH_P!m
 l
end

_________
 |\___/|	Vincent Archer
 | \ / |	Email: archer%segin4.segin.fr@relay.prime.com
 | /|\ |
 |// \\|
-+-----+-	"Time is running fast..."