cwr@pnet01.cts.com (Will Rose) (06/26/91)
Several people have taken a look at the UUCP package I posted a couple of days back, and while it is generally functional, several things are doubtful/confusing/wrong. In about 10 days I'll post a set of patches to deal with everything that's been reported, but meanwhile there are two important bugs: The first is in mdial.c, part of the dial package. This sets an alarm when talking to the modem, and never clears it. Dialling out therefore works long enough to give a false sense of confidence, but not long enough to do anything useful... The patch is simple, and easiest done by hand: the diff is below. 62,65c63,68 < return(0); < } < return(0); < } --- > } > alarm(0); > signal(SIGALRM, SIG_DFL); > return(0); > } > I'm not sure if alarm(0) resets alarm to SIG_DFL, but an explicit reset doesn't cost any extra. Why the dial package ever worked is a mystery. The other problem is in uupick, where I reversed the arguments to fputc; again, why this worked at all is odd. There's only one call to fputc; just reverse the order of the arguments. Finally, the man pages talk about a connection between the SQFILE and the callback flag. This is nonsense; please ignore it (tactfully). The patches will include a revised and more complete manual, with better installation instructions, and some other doc files. At the moment I'm trying to find out why the protocol driver barfs on command strings longer than the packet length. I'm not sure if this is a feature of the UUCP I'm talking to, or a general limitation. The packet mechanism should be transparent at the command level, and at the moment it certainly is not. Pity, I'd hoped to avoid hacking the driver. Thanks for all your help - Will ----------------------------------------------------------------------- "If heaven too had passions | Will Rose even heaven would | UUCP: {nosc ucsd hplabs!hp-sdd}!crash!pnet01!cw grow old." - Li Ho. | ARPA: crash!pnet01!cwr@nosc.mil | INET: cwr@pnet01.cts.com UUCP: {nosc ucsd hplabs!hp-sdd}!crash!pnet01!cwr ARPA: crash!pnet01!cwr@nosc.mil INET: cwr@pnet01.cts.com