[comp.sources.bugs] latest conquest bug report

stucki@perch.cis.ohio-state.edu (David J. Stucki) (01/22/88)

Here is the latest bug in (Barlow's) conquest I found that I haven't
seen reported elsewhere.

It doesn't show up as long as the world is square, i.e., 48x48 or 64x64, etc.
However, we tried to set it up as 64x32 and it came back with floating
exception in main.c at a call to refresh();

Well, it appears that there are several places (10 to 15) where a reference
to MAPX is made when it should be MAPY. Something like this:

	for(i=0;i<MAPX;i++) for(j=0;j<MAPX;j++) fought[i][j]=0;
where it should be 
	for(i=0;i<MAPX;i++) for(j=0;j<MAPY;j++) fought[i][j]=0;
(this one was in combat.c)

We went through and found them all: do a fgrep MAXY on files combat.c
move.c reports.c and update.c. That was all the ones as far as we can tell
because now it works again.
-=-
~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~+~
David J Stucki					c/o Dept. Computer and 
P.O. Box 713 Park Hall				    Information Science
110 W. 11th Ave.				    2036 Neil Ave.

adb@bucsb.UUCP (Adam Bryant) (01/24/88)

In article <5030@tut.cis.ohio-state.edu> stucki@perch.cis.ohio-state.edu (David J. Stucki) writes:
>
>Here is the latest bug in (Barlow's) conquest I found that I haven't
>seen reported elsewhere.
>
>Well, it appears that there are several places (10 to 15) where a reference
>to MAPX is made when it should be MAPY. Something like this:
>
>	for(i=0;i<MAPX;i++) for(j=0;j<MAPX;j++) fought[i][j]=0;
>where it should be 
>	for(i=0;i<MAPX;i++) for(j=0;j<MAPY;j++) fought[i][j]=0;
>(this one was in combat.c)


this also occurs within the recent conquer distribution as well, 

I can't implement it to test other bugs as there was no
HEADER.H file distrubuted with the conquer posting!!!!!!!!!!!

could someone who has the first distribution source email me the 
header.h file.

(you would figure that someone would catch something like
that before they distrubute)
-- 
    Adam Bryant                     ||  ARPANET: adb@bucsb.bu.edu 
    91 Bay State Rd                 ||  BITNET: adb@buenga engb0du@bostonu
    Boston, MA  02215               ||  UUCP: ..!harvard!bu-cs!bucsb!adb
    (617) 375-7380                  ||  CSNET: adb%bucsb@bu-cs