tim@dciem.UUCP (Tim Pointing) (02/11/88)
(I may have missed seeing a patch fail but I don't think so...) After applying patch 18, attempts to compile perl bombed out. The problem seems to be in perl.h ... in that file "COMPEX" is typedef'ed as a specific structure. Alas, in search.h, there is an attempt to declare COMPEX as an instance of a structure. I got perl to compile by commenting out the typedef in perl.h . Is this the right thing to do? Did I screw up somewhere or is everybody else having this trouble too? Tim Pointing, DCIEM tim@zorac.arpa, uunet!mnetor!dciem!tim P.S. If it matters (and I don't think that it should at this stage), this is on a Sun 3 under SunOS 3.4 -- Tim Pointing, DCIEM {decvax|ihnp4|watmath}!utzoo!dciem!tim or uw-beaver!utcsri!dciem!tim or uunet!mnetor!dciem!tim or dciem!tim@zorac.arpa
mohamed@hscfvax.harvard.edu (Mohamed_el_Lozy) (02/16/88)
In article <2641@dciem.UUCP> tim@dciem.UUCP (Tim Pointing) writes: >(I may have missed seeing a patch fail but I don't think so...) > A patch (#18) DID fail. However, with the verbose output of patch it is very easy to miss. I did, and wondered what on earth was going on. How useful is the verbose output of patch? Does ity serve any purpose (other than as a debugging tool while patch was being developped)? Is there a way to shut it up? My feeling is that optimal behavior would be no output other than a patch succeedded or patch failed message. That would be impossible to miss. Even more in the UNIX tradition would be no message at all unless it failed.
lwall@devvax.JPL.NASA.GOV (Larry Wall) (02/17/88)
In article <513@hscfvax.harvard.edu> mohamed@hscfvax.harvard.edu (Mohamed_el_Lozy) writes:
: How useful is the verbose output of patch? Does ity serve any purpose (other
: than as a debugging tool while patch was being developped)? Is there a
: way to shut it up?
:
: My feeling is that optimal behavior would be no output other than a patch
: succeedded or patch failed message. That would be impossible to miss. Even
: more in the UNIX tradition would be no message at all unless it failed.
Try -s. That's why it's there. It's even documented.
If you're going to apply a lot of patches you probably want to put it in a loop
that checks the exit status each time and refuses to go on if there's a problem.
Larry Wall
lwall@jpl-devvax.jpl.nasa.gov