[comp.sources.bugs] Small bug in Touchup, the bitmap editor.

richb@sunaus.oz (Rich Burridge) (06/15/88)

I see the problem on a 3/60C-8-327 running 4.0(FCS)(EXPORT).
Touchup core dumps with a segmentation violation whilst trying
to copy the current screen contents to a temporary buffer, so the
undo command will work if used. This is because the pixrect pointer
for that temporary buffer is a nil pointer.

The memory create routine in touchup.c called my_memory_create is
failing to return the newly created pixrect pointer. The fix is simple:

*** touchup.c.original  Wed Jun 15 18:08:36 1988
--- touchup.c   Wed Jun 15 18:08:20 1988
***************
*** 775,778 ****
--- 775,779 ----
        printf("Not enough memory, memory allocation problems!!!\n");
        exit(0);
          }
+     return(temp_pr);
  }

This is a fantastic program. My hat is off to the author.

    Rich.

txt@edsdrd.UUCP (Viet) (06/21/88)

In article <175@sunaus.oz>, richb@sunaus.oz (Rich Burridge) writes:
> 
> This is a fantastic program. My hat is off to the author.
> 
>     Rich.


 Mine, also  ...  This is one of the best graphics tool for
 the Sun I have encountered so far ...

        BRAVO !!


-- 
Tri Tran-Viet                             USENET:  ... ihnp4!mibte!edsdrd!txt
General Motors-Electronic Data Systems
Research and Development - Applied A.I.
-------------------------------------------------------------------------------

rayk@sbcs.sunysb.edu (Raymond T Kreisel) (06/22/88)

The bug you mention in the my_mem_create has been fixed
in the new version of touchup ( the patches were posted
to comp.sources.unix recently).

		ray

---------------------------------------------------------------------------
 Ray Kreisel   CS Dept., SUNY at Stony Brook, Stony Brook NY 11794
UUCP: {allegra, philabs, pyramid, research}!sbcs!rayk   
ARPA-Internet: rayk@sbcs.sunysb.edu			CSnet: rayk@suny-sb
 "If I get home before daylight, I just might get some sleep tonight...."
---------------------------------------------------------------------------