[comp.sources.bugs] Bug in patch 2.0

jonathan@cs.keele.ac.uk (Jonathan Knight) (05/30/89)

I tried to apply patch 8 to the elm system and found that patch
bombed out with an asserion error.  So I invoked patch like
this:

patch -p -N -x511 < patch8 

And here's what the end of the output looked like:

---------------------------------------------
 29     
 30             if (! retransmit && copy_msg != FORM)
 31               if (reply != NULL)
 32                 (void) fclose(reply);       /* on replies, it won't be open! */
Hunk #5 succeeded at 172.
fillsrc 66, filldst 8, rb 8, e+1 67
Assertion failed: file pch.c, line 719
% 
---------------------------------------------

Here's what the patch file (patch8) looks like around the hunk that
caused the problem:

---------------------------------------------
-
        if (! retransmit && copy_msg != FORM)
          if (reply != NULL)
            (void) fclose(reply);       /* on replies, it won't be open! */
--- 172,177 ----
***************
*** 322,328 ****
--- 309,366 ----

        }
        else {
+
          copy_message_across(reply, real_reply, FALSE);
+
+           /* Append signature */
+

****** THERE ARE >30 LINES STARTING + HERE ******

+               strcpy(filename2, sig);
+             (void) append(real_reply,+             }
+           }
 
          fclose(real_reply);
  

Index: src/mkhdrs.c
Prereq: 2.7
*** ../elm2.2/src/mkhdrs.c      Thu Mar 30 10:36:33 1989
--- src/mkhdrs.c  
---------------------------------------------

Any help would be appreciated...


-- 
  ______    JANET :jonathan@uk.ac.keele.cs     Jonathan Knight,
    /       BITNET:jonathan%cs.kl.ac.uk@ukacrl Department of Computer Science
   / _   __ other :jonathan@cs.keele.ac.uk     University of Keele, Keele,
(_/ (_) / / UUCP  :...!ukc!kl-cs!jonathan      Staffordshire.  ST5 5BG.  U.K.

bs@sbsvax.UUCP (Bernard Sieloff) (06/07/89)

In article <618@kl-cs.UUCP>, jonathan@cs.keele.ac.uk (Jonathan Knight) writes:
> I tried to apply patch 8 to the elm system and found that patch
> bombed out with an asserion error.  So I invoked patch like
> this:
> [...]
> Any help would be appreciated...

Some characters got lost in patch #8.
Try this patch to patch the patch #8 :-)
BTW: tabstop=8

*** patch.08.orig	Sat May 27 15:32:00 1989
--- patch.08	Sat May 27 17:02:51 1989
***************
*** 1055,1061 ****
  + 	        sprintf(filename2, "%s/%s", home, sig);
  + 	      else
  + 	        strcpy(filename2, sig);
! + 	      (void) append(real_reply,+             }
  +           }
    
    	  fclose(real_reply);
--- 1055,1062 ----
  + 	        sprintf(filename2, "%s/%s", home, sig);
  + 	      else
  + 	        strcpy(filename2, sig);
! + 	      (void) append(real_reply, filename2);
! +             }
  +           }
    
    	  fclose(real_reply);
-- 
 Bernard Sieloff                    | UUCP:  ...!uunet!unido!sbsvax!bs
 Universitaet des Saarlandes        | CSNET: bs%sbsvax@ira.uka.de
 FB 10 - Informatik (Dept. of CS)   | ARPA:  bs%sbsvax.uucp@uunet.UU.NET
 Bau 36, Im Stadtwald 15            | ICBM:  49 15 20 N / 07 02 30 E
 D-6600 Saarbruecken 11, W. Germany | Phone: +49 681 302 2434
          X400: bs@sbsvax.informatik.uni-saarland.dbp.de