[comp.mail.misc] ucbmail question

haynes@ucscc.UCSC.EDU (99700000) (11/10/90)

From time to time when reading mail we see 
"do_quoted_string: cp2p is not null".
Does anybody know what this really means, and whether it is something
to worry about.

haynes@ucscc.ucsc.edu
haynes@ucscc.bitnet
..ucbvax!ucscc!haynes

"Any clod can have the facts, but having opinions is an Art."
        Charles McCabe, San Francisco Chronicle

jnford@handlebar.weeg.uiowa.edu (Jay Ford) (11/10/90)

In article <8710@darkstar.ucsc.edu>, haynes@ucscc.UCSC.EDU (99700000) writes:
|> From time to time when reading mail we see 
|> "do_quoted_string: cp2p is not null".
|> Does anybody know what this really means, and whether it is something
|> to worry about.

That message is the result of a little debugging code which snuck out in a fix
I posted to the net last November.  I reposted the fix without the debugging
code, but you seem to have the first (verbose) version.  The message is
completey extraneous.

The fix involved the parsing of quoted and commented strings in mail addresses,
so you only see the debug message when dealing with addresses containing double
quotes (").  Right?  Attached below is an excerpt from my posting.

To supress the message, simply delete the debugging code in /usr/ucb/Mail/aux.c
as follows, and rebuild Mail.

------------------------------------------------------------------------------
diff -c aux.c.debug aux.c
*** aux.c.debug Fri Dec  8 13:49:21 1989
--- aux.c       Fri Dec  8 13:49:28 1989
***************
*** 678,686 ****
  {
        register int c;

-       if ( cp2p != NULL ) printf ( "do_quoted_string: cp2p is not null\n" );
-       else printf ( "do_quoted_string: cp2p is null\n" );
-
        while ((c = *cp) != 0) {
                cp++;
                switch (c) {
--- 678,683 ----
------------------------------------------------------------------------------

If you don't have source, you might be stuck with the message.

I'm glad to see my parsing fix is getting used.  I apologize for the
extraneous output.


Jay Ford,  Weeg Computing Center,  University of Iowa,  Iowa City,  IA  52242
jnford@handlebar.weeg.uiowa.edu  or  jnfordpb@uiamvs.bitnet,  319-335-5555

------------------------------------------------------------------------------

Subject: address parsing bug in Berkeley mail (/usr/ucb/Mail)
Index: UCB Mail Version 5.2 (6/21/85)

Description:
        There is a parsing bug in the routine skin in aux.c which causes it
        to mangle mail addresses containing quoted or commented strings
        following an address in angle brackets.

Problem found on:
        IBM RT running IBM/4.3 rel 2 (Dec 1988);
        NeXT running MACH 1.0;
        VAX running 4.3BSD;
        Sun running SunOS Release 4.0

Rebeat-by:
        Get mail from someone with an address like
                <jnford@jay.weeg.uiowa.edu> "commas, in, quotes"
        or
                <jnford@jay.weeg.uiowa.edu> (commas, in, a, comment)
        This can be done by saving a piece of mail, hacking the from line,
        and using mail -f on the file.

Fix:
        Apply the following patches in /usr/src/ucb/Mail.

[patches deleted]