[comp.emacs] diff of fix to SUPERYANK v1.1

warsaw@cme.nist.gov (Barry A. Warsaw) (06/22/89)

A couple of people pointed out a small bug in the just recently posted
version 1.1. The fix was easy and the bug might be annoying so I
figured I'd post the diff.  You can recreate the bug by entering the
following text in a reply buffer, moving point to the character "X"
then yanking the original message (C-c C-y):

==========
aaaaaaaaaa
Xbbbbbbbbb
cccccccccc
==========

Thanks to those who pointed this out.

-Barry

-------cut here-------------------------------------------------------
*** superyank.el.posted.v1.1	Mon Jun 19 17:59:30 1989
--- superyank.el	Wed Jun 21 19:15:41 1989
***************
*** 1,3 ****
! ;; superyank.el -- Version 1.1
  ;;
  ;; Inserts the message being replied to with various user controlled
--- 1,3 ----
! ;; superyank.el -- Version 1.11
  ;;
  ;; Inserts the message being replied to with various user controlled
***************
*** 27,30 ****
--- 27,33 ----
  ;; Modification history:
  ;;
+ ;; Posted  : 21-Jun-1989 baw (diffs-1.1-1.11)
+ ;; modified: 19-Jun-1989 baw (fixed yanking inside existing text bug)
+ ;; Posted  : 19-Jun-1989 baw (version 1.1)
  ;; modified: 14-Jun-1989 baw (better keymap set procedure, rewrite-headers)
  ;; modified: 12-Jun-1989 baw (added defvar for sy-use-only-preference-p)
***************
*** 33,36 ****
--- 36,40 ----
  ;; modified:  1-Jun-1989 baw (persistent attribution, sy-open-line)
  ;; modified: 31-May-1989 baw (fixed some gnus problems, id'd another)
+ ;; Posted  : 23-May-1989 baw (version 1.0)
  ;; modified: 22-May-1989 baw (documentation)
  ;; modified:  8-May-1989 baw (auto filling of regions)
***************
*** 863,871 ****
  	     (attribution (sy-scan-rmail-for-names mail-reply-buffer))
  	     (top (point))
! 	     (start (point))
! 	     (end (progn (delete-windows-on mail-reply-buffer)
! 			 (insert-buffer mail-reply-buffer)
! 			 (mark))))
! 	
  	(sy-yank-fields start)
  	(sy-rewrite-headers start)
--- 867,874 ----
  	     (attribution (sy-scan-rmail-for-names mail-reply-buffer))
  	     (top (point))
! 	     (start (point)))
! 
! 	(delete-windows-on mail-reply-buffer)
! 	(insert-buffer mail-reply-buffer)
  	(sy-yank-fields start)
  	(sy-rewrite-headers start)
***************
*** 873,877 ****
  	(mail-yank-clear-headers top (mark))
  	(setq sy-persist-attribution (concat attribution " "))
! 	(sy-insert-citation start end attribution))
      
      (goto-char top)
--- 876,880 ----
  	(mail-yank-clear-headers top (mark))
  	(setq sy-persist-attribution (concat attribution " "))
! 	(sy-insert-citation start (mark) attribution))
      
      (goto-char top)