[comp.emacs] server.el problems

scott@grlab.UUCP (Scott Blachowicz) (10/06/89)

Problem 1:
   I've noticed a problem with running the emacsclient/server stuff on
   our site with GnuEmacs 18.54. It looks like the server program will do
   multiple printf's to Emacs when the number of files being edited is
   large. This caused the function server-process-filter in server.el to
   be called multiple times. Since this function looks for lines starting
   with "Client: ", it would miss the 2nd and following printf's from the
   server program. I did some mods to our server.el to have it look for
   the terminating "\n" before deciding that it has all the files to be
   visited. If the last char in the string isn't "\n", the string is just
   appended to a "pending line" variable.

   This fix could lose if two emacsclients runs happen at the same
   time causing the server program to get requests interweaved with each
   other. I would judge the chances of this as fairly small.

Problem 2:
   In testing my fix for the above problem, I've noticed a problem when
   lots of buffers are edited in this manner. I ran emacsclient over
   a lot of files, then went into the Buffer-menu and deleted them.
   When I then ran 'server-edit' to return, I get an error about max eval
   depth being exceeded. It looks like 'server-switch-buffer' recurses
   for each buffer in the list (at least). This isn't really much of a
   problem since it takes an awful lot of files to cause this.

Questions:
   -Are there any problems with this?
   -Should I send the patch to the bugs mailing list? or post it?

--
Scott Blachowicz                E-mail:  scott@grlab.UUCP
USPS:  Graphicus                 ..or..  ...!hpubvwa!grlab!scott
       150 Lake Str S, #206     VoicePh: 206/828-4691
       Kirkland, WA 98033       FAX:     206/828-4236