[news.software.notes] Checknotes Bug Report

cmv@ihuxz.UUCP (04/12/87)

References:

I reported a bug in checknotes earlier this month, and the fix that I proposed
was incorrect. Here is the correct fix:

The fix for this problem is in 2 files: checknotes.c and Makefile.

checknotes.c

---Original---
81  */
82     if (opennf (&io, nfname) < 0)
83         return 0;                                    /* ignore this one */
84     getdscr (&io, &io.descr);
85    getlast (&io.stime, io.nf, NORMSEQ, Seqname);	/* last date */


---Modified---  Lines 85 and 86 have been added
81  */
82    if (opennf (&io, nfname) < 0)
83	return 0;					/* ignore this one */
84    getdscr (&io, &io.descr);
85    if(allow(&io,READOK) != 0)
86	return 0;
87    getlast (&io.stime, io.nf, NORMSEQ, Seqname);	/* last date */

Makefile

---Original---
85 CHECKNOTES = check.o cursor.o gname.o gtime.o lrsp.o misc.o miscio.o \
86         next.o pattern.o perms.o recsio.o startup.o times.o expand.o

---Modified---
85  CHECKNOTES = check.o cursor.o gname.o gtime.o lrsp.o misc.o miscio.o \
86         next.o pattern.o permit.o perms.o recsio.o startup.o times.o expand.o
                            ^^^^^^^^^
This fix is intended to properly inform folks if they have any unread groups
in notesfiles that they have permission to read. For this to work properly
FASTSEQ *must* be undefined since the code that gets included when FASTSEQ is
defined ignores wether the user is allowed to read the notesfile or not.

Craig Votava
AT&T Bell Labs, Naperville IL.
IH 4G-324 312/979-2542

ihnp4!ihlpm!cmv
ihnp4!ih3b1!cmv
ihnp4!ihuxz!cmv